From: Mike Hommey <mh@glandium.org>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v8 0/9] connect: various cleanups
Date: Sat, 28 May 2016 17:47:15 +0900 [thread overview]
Message-ID: <20160528084715.GA13770@glandium.org> (raw)
In-Reply-To: <5ba52c0a-2b8f-91af-d823-9519cdb9f67c@web.de>
On Sat, May 28, 2016 at 10:17:19AM +0200, Torsten Bögershausen wrote:
> On 28.05.16 07:33, Mike Hommey wrote:
> > On Sat, May 28, 2016 at 07:02:01AM +0200, Torsten Bögershausen wrote:
> >> On 27.05.16 23:59, Mike Hommey wrote:
> >>> On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote:
> >>>> On 27.05.16 04:27, Mike Hommey wrote:
> >>>>> Changes from v7:
> >>>>> - Fixed comments.
> >>>>>
> >>>>> Mike Hommey (9):
> >> All in all, a great improvement.
> >> 2 things left.
> >> - The comment about [] is now stale, isn't it ?
> > No, it's still valid at this point, that's what the 2nd argument to
> > host_end (0) does.
> >
> > Mike
>
> The protocol (specific) code doesn't do this anymore,
> because that is now common to all protocols.
>
>
> /*
> * Don't do destructive transforms now, the
> * '[]' unwrapping is done in get_host_and_port()
> */
>
I'm not following what you're saying. The code explicitly calls host_end
so that it doesn't remove the square brackets from the string it's
passed. That's what the comment says, and that's what happens.
Mike
prev parent reply other threads:[~2016-05-28 8:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 2:27 [PATCH v8 0/9] connect: various cleanups Mike Hommey
2016-05-27 2:27 ` [PATCH v8 1/9] connect: document why we sometimes call get_port after get_host_and_port Mike Hommey
2016-05-27 2:27 ` [PATCH v8 2/9] connect: call get_host_and_port() earlier Mike Hommey
2016-05-27 2:27 ` [PATCH v8 3/9] connect: re-derive a host:port string from the separate host and port variables Mike Hommey
2016-05-27 2:27 ` [PATCH v8 4/9] connect: make parse_connect_url() return separated host and port Mike Hommey
2016-05-27 2:27 ` [PATCH v8 5/9] connect: group CONNECT_DIAG_URL handling code Mike Hommey
2016-05-27 2:27 ` [PATCH v8 6/9] connect: make parse_connect_url() return the user part of the url as a separate value Mike Hommey
2016-05-27 2:27 ` [PATCH v8 7/9] connect: change the --diag-url output to separate user and host Mike Hommey
2016-05-27 2:27 ` [PATCH v8 8/9] connect: actively reject git:// urls with a user part Mike Hommey
2016-05-27 2:27 ` [PATCH v8 9/9] connect: move ssh command line preparation to a separate function Mike Hommey
2016-05-27 14:24 ` [PATCH v8 0/9] connect: various cleanups Torsten Bögershausen
2016-05-27 21:59 ` Mike Hommey
2016-05-28 5:02 ` Torsten Bögershausen
2016-05-28 5:33 ` Mike Hommey
2016-05-28 8:17 ` Torsten Bögershausen
2016-05-28 8:47 ` Mike Hommey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160528084715.GA13770@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).