From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Hommey Subject: Re: [PATCH v8 0/9] connect: various cleanups Date: Sat, 28 May 2016 17:47:15 +0900 Message-ID: <20160528084715.GA13770@glandium.org> References: <20160527022756.22904-1-mh@glandium.org> <20160527215943.GA21018@glandium.org> <5071966e-6bce-fa91-8837-81cb3c9157f7@web.de> <20160528053354.GA3860@glandium.org> <5ba52c0a-2b8f-91af-d823-9519cdb9f67c@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org To: Torsten =?iso-8859-15?Q?B=F6gershausen?= X-From: git-owner@vger.kernel.org Sat May 28 10:47:35 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b6ZuB-0007NE-8Z for gcvg-git-2@plane.gmane.org; Sat, 28 May 2016 10:47:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751163AbcE1IrY convert rfc822-to-quoted-printable (ORCPT ); Sat, 28 May 2016 04:47:24 -0400 Received: from ns332406.ip-37-187-123.eu ([37.187.123.207]:57498 "EHLO glandium.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbcE1IrW (ORCPT ); Sat, 28 May 2016 04:47:22 -0400 Received: from glandium by zenigata with local (Exim 4.87) (envelope-from ) id 1b6Ztr-0003gs-O6; Sat, 28 May 2016 17:47:15 +0900 Content-Disposition: inline In-Reply-To: <5ba52c0a-2b8f-91af-d823-9519cdb9f67c@web.de> X-GPG-Fingerprint: 182E 161D 1130 B9FC CD7D B167 E42A A04F A6AA 8C72 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, May 28, 2016 at 10:17:19AM +0200, Torsten B=F6gershausen wrote: > On 28.05.16 07:33, Mike Hommey wrote: > > On Sat, May 28, 2016 at 07:02:01AM +0200, Torsten B=F6gershausen wr= ote: > >> On 27.05.16 23:59, Mike Hommey wrote: > >>> On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten B=F6gershausen = wrote: > >>>> On 27.05.16 04:27, Mike Hommey wrote: > >>>>> Changes from v7: > >>>>> - Fixed comments. > >>>>> > >>>>> Mike Hommey (9): > >> All in all, a great improvement. > >> 2 things left. > >> - The comment about [] is now stale, isn't it ? > > No, it's still valid at this point, that's what the 2nd argument to > > host_end (0) does. > > > > Mike >=20 > The protocol (specific) code doesn't do this anymore,=20 > because that is now common to all protocols. >=20 >=20 > /* > * Don't do destructive transforms now, the > * '[]' unwrapping is done in get_host_and_port() > */ >=20 I'm not following what you're saying. The code explicitly calls host_en= d so that it doesn't remove the square brackets from the string it's passed. That's what the comment says, and that's what happens. Mike