From: Thomas Gummerer <t.gummerer@gmail.com>
To: Dave Nicolson <david.nicolson@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Do not output whitespace on blank lines
Date: Sun, 29 May 2016 18:06:37 +0100 [thread overview]
Message-ID: <20160529170637.GC2286@hank> (raw)
In-Reply-To: <01020154fd28aa12-f536bf3e-58df-4d1f-b903-929b429954d3-000000@eu-west-1.amazonses.com>
On 05/29, Dave Nicolson wrote:
> ---
The commit message should describe why you think this is a good
change. Without the commit message I don't see how this is a
improvement. It is also missing your Sign-off (see
Documentation/SubmittingPatches section 5).
The test changes you sent in Patch 2/2 should be in this commit,
otherwise the git bisect is broken when it hits this patch, which is
something we want to avoid.
> diff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/diff.c b/diff.c
> index d3734d3..459b36a 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -471,7 +471,7 @@ static void emit_line_0(struct diff_options *o, const char *set, const char *res
> has_trailing_carriage_return = (len > 0 && line[len-1] == '\r');
> if (has_trailing_carriage_return)
> len--;
> - nofirst = 0;
> + nofirst = len == 0 && (char)first == ' ' ? 1 : 0;
> }
>
> if (len || !nofirst) {
>
> --
> https://github.com/git/git/pull/245
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thomas
next prev parent reply other threads:[~2016-05-29 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 15:36 [PATCH 1/2] Do not output whitespace on blank lines Dave Nicolson
2016-05-29 15:36 ` [PATCH 2/2] Fix tests Dave Nicolson
2016-05-29 17:06 ` Thomas Gummerer [this message]
2016-05-29 17:25 ` [PATCH 1/2] Do not output whitespace on blank lines René Scharfe
2016-05-30 0:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160529170637.GC2286@hank \
--to=t.gummerer@gmail.com \
--cc=david.nicolson@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).