From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t4014: shell portability fix
Date: Tue, 31 May 2016 23:54:08 -0400 [thread overview]
Message-ID: <20160601035408.GD5411@sigill.intra.peff.net> (raw)
In-Reply-To: <20160601034413.GC5411@sigill.intra.peff.net>
On Tue, May 31, 2016 at 11:44:13PM -0400, Jeff King wrote:
> # probably not portable; also, possible without sub-program?
> is_exported () {
> export -p | grep "^declare -x $1="
> }
Obviously this should have been "grep -q" (and my test didn't notice
because the variable isn't actually exported!).
But yeah, this is not very portable. Doing:
export AAAA=content
for i in bash dash mksh ksh93
do
printf '%5s ==> ' $i
$i -c 'export -p' | head -1
done
yields:
bash ==> declare -x AAAA="content"
dash ==> export AAAA='content'
mksh ==> export AAAA=content
ksh93 ==> export AAAA=content
which is actually not too hard to pattern-match, but who knows what else
exists. I guess another strategy would be to actually spawn a
sub-process and see if it has the variable set.
I think my code also doesn't handle exported-but-unset variables, though
I'm not sure we really need to care about that in practice.
-Peff
next prev parent reply other threads:[~2016-06-01 3:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:53 [PATCH] t4014: shell portability fix Junio C Hamano
2016-05-31 22:56 ` Jeff King
2016-06-01 0:09 ` Eric Sunshine
2016-06-01 2:31 ` Jeff King
2016-06-01 3:31 ` Jeff King
2016-06-01 3:44 ` Jeff King
2016-06-01 3:54 ` Jeff King [this message]
2016-06-01 5:33 ` Jeff King
2016-06-01 5:40 ` Jeff King
2016-06-01 6:49 ` Junio C Hamano
2016-06-01 6:57 ` Junio C Hamano
2016-06-01 7:04 ` Jeff King
2016-06-01 15:07 ` Junio C Hamano
2016-06-01 16:07 ` Jeff King
2016-06-01 16:57 ` Junio C Hamano
2016-06-01 16:58 ` Jeff King
2016-06-01 5:48 ` Johannes Sixt
2016-06-01 5:48 ` Jeff King
2016-06-01 6:39 ` Eric Sunshine
2016-06-01 0:09 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601035408.GD5411@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).