From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Lars Schneider <larsxschneider@gmail.com>
Subject: Re: [RCF/PATCH] Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion
Date: Wed, 1 Jun 2016 03:30:37 -0400 [thread overview]
Message-ID: <20160601073037.GA14096@sigill.intra.peff.net> (raw)
In-Reply-To: <20160531132443.5033-1-Matthieu.Moy@imag.fr>
On Tue, May 31, 2016 at 03:24:43PM +0200, Matthieu Moy wrote:
> The DEVELOPER knob was introduced in 658df95 (add DEVELOPER makefile
> knob to check for acknowledged warnings, 2016-02-25), and works well
> when used as "make DEVELOPER=1", and when the configure script was not
> used.
>
> However, the advice given in CodingGuidelines to add DEVELOPER=1 to
> config.mak does not: config.mak is included after testing for
> DEVELOPER in the Makefile, and at least GNU Make's manual specifies
> "Conditional directives are parsed immediately", hence the config.mak
> declaration is not visible at the time the conditional is evaluated.
>
> Also, when using the configure script to generate a
> config.mak.autogen, the later file contained a "CFLAGS = <flags>"
> initialization, which overrode the "CFLAGS += -W..." triggered by
> DEVELOPER.
>
> This patch fixes both issues.
Hmm. So I think this does fix some issues, but it also means that one's
config.mak cannot use DEVELOPER as a base and then override particular
flags.
I dunno if people want to do that or not. I do not use DEVELOPER myself
because I have my own detailed config.mak that is a superset.
-Peff
next prev parent reply other threads:[~2016-06-01 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:24 [RCF/PATCH] Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion Matthieu Moy
2016-05-31 17:00 ` Junio C Hamano
2016-06-01 7:30 ` Jeff King [this message]
2016-06-01 7:57 ` Matthieu Moy
2016-06-01 8:00 ` [PATCH] Makefile: add $(DEVELOPER_CFLAGS) variable Matthieu Moy
2016-06-01 8:03 ` [RCF/PATCH] Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion Jeff King
2016-06-01 8:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601073037.GA14096@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).