From: Jeff King <peff@peff.net>
To: John Keeping <john@keeping.me.uk>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [BUG] git-submodule has bash-ism?
Date: Wed, 1 Jun 2016 16:32:43 -0400 [thread overview]
Message-ID: <20160601203243.GA15490@sigill.intra.peff.net> (raw)
In-Reply-To: <20160601202852.GP1355@john.keeping.me.uk>
On Wed, Jun 01, 2016 at 09:28:53PM +0100, John Keeping wrote:
> > So either way, I do not think "local variable names" that breaks
> > &&-chain can be justified. Either the variable must be localized
> > for the script to work correctly, in which case we want local with
> > &&-chaining, or it does not have to, in which case we do not want to
> > have "local" that is not necessary, no?
>
> Absolutely, my original point should have been prefixed with: I wonder
> if the reason we haven't had any problems reported is because ...
>
> And we've got lucky because the clobbering of global variables happens
> not to matter in these particular cases.
Ah, OK, what you were saying makes much more sense to me now, then.
Even on a shell like ksh93 that does not grok local at all, there is a
good chance that nobody ever looked at the "-v" output for the test,
which would not have been failing, to see that it was complaining.
So I agree we can't really take "no problems reported" on these existing
cases as any kind of data point.
-Peff
next prev parent reply other threads:[~2016-06-01 20:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 23:08 [BUG] git-submodule has bash-ism? Junio C Hamano
2016-05-31 23:16 ` Stefan Beller
2016-06-01 0:27 ` [PATCH] submodule: remove bashism from shell script Stefan Beller
2016-06-01 16:13 ` [BUG] git-submodule has bash-ism? Junio C Hamano
2016-06-01 16:19 ` Junio C Hamano
2016-06-01 16:37 ` Jeff King
2016-06-01 18:31 ` John Keeping
2016-06-01 19:07 ` Jeff King
2016-06-01 19:16 ` John Keeping
2016-06-01 19:45 ` Junio C Hamano
2016-06-01 20:28 ` John Keeping
2016-06-01 20:32 ` Jeff King [this message]
2016-06-01 20:48 ` Junio C Hamano
2016-06-01 20:56 ` Junio C Hamano
2016-06-01 20:59 ` Eric Sunshine
2016-06-01 21:08 ` Jeff King
2016-06-01 20:59 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601203243.GA15490@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).