From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Lukas Fleischer <lfleischer@lfos.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Mark remote `gc --auto` error messages
Date: Thu, 2 Jun 2016 18:04:55 -0400 [thread overview]
Message-ID: <20160602220454.GA17202@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqmvn3s148.fsf@gitster.mtv.corp.google.com>
On Thu, Jun 02, 2016 at 02:59:51PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > So the greater question is not "should this output be marked" but
> > "should auto-gc data go over the sideband so that all clients see it
> > (and any server-side stderr does not)". And I think the answer is
> > probably yes. And that fixes the "remote: " thing as a side effect.
>
> Thanks for stating this a lot more clearly than I could, and I agree
> that sending this to the other side regardless of the protocol is
> the right thing. I somehow doubt that server operators would check
> Apache logs to decide when to do a proper GC, so I do not consider
> it a true loss ;-)
I definitely agree. I'd wonder more about "would they want their users
to see these details". I dunno. I am only intimately familiar with one
git hosting site, and we turn off auto-gc completely.
-Peff
next prev parent reply other threads:[~2016-06-02 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 19:05 Mark remote `gc --auto` error messages Lukas Fleischer
2016-06-02 19:33 ` Junio C Hamano
2016-06-02 20:06 ` Lukas Fleischer
2016-06-02 20:14 ` Junio C Hamano
2016-06-02 21:48 ` Jeff King
2016-06-02 21:59 ` Junio C Hamano
2016-06-02 22:04 ` Jeff King [this message]
2016-06-02 21:53 ` Jeff King
2016-06-05 9:36 ` [PATCH] receive-pack: send auto-gc output over sideband 2 Lukas Fleischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602220454.GA17202@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lfleischer@lfos.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).