From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Hommey Subject: Re: What's cooking in git.git (Jun 2016, #01; Thu, 2) Date: Fri, 3 Jun 2016 08:13:15 +0900 Message-ID: <20160602231315.GA22864@glandium.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org, tboegi@web.de To: Junio C Hamano X-From: git-owner@vger.kernel.org Fri Jun 03 01:13:26 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b8bnq-0007dE-2v for gcvg-git-2@plane.gmane.org; Fri, 03 Jun 2016 01:13:26 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932942AbcFBXNW (ORCPT ); Thu, 2 Jun 2016 19:13:22 -0400 Received: from ns332406.ip-37-187-123.eu ([37.187.123.207]:39652 "EHLO glandium.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbcFBXNV (ORCPT ); Thu, 2 Jun 2016 19:13:21 -0400 Received: from glandium by zenigata with local (Exim 4.87) (envelope-from ) id 1b8bnf-0005zF-5j; Fri, 03 Jun 2016 08:13:15 +0900 Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 182E 161D 1130 B9FC CD7D B167 E42A A04F A6AA 8C72 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Jun 02, 2016 at 03:52:41PM -0700, Junio C Hamano wrote: > * mh/connect (2016-06-01) 9 commits > - connect: move ssh command line preparation to a separate function > - connect: actively reject git:// urls with a user part > - connect: change the --diag-url output to separate user and host > - connect: make parse_connect_url() return the user part of the url as a separate value > - connect: group CONNECT_DIAG_URL handling code > - connect: make parse_connect_url() return separated host and port > - connect: re-derive a host:port string from the separate host and port variables > - connect: call get_host_and_port() earlier > - connect: document why we sometimes call get_port after get_host_and_port > > Needs review. I /think/ Torsten reviewed it all, and his last comments are in $gmane/295800. It's still not clear to me why he wants to remove the comment about []. Mike