git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2016, #01; Thu, 2)
Date: Sat, 4 Jun 2016 14:14:58 +0900	[thread overview]
Message-ID: <20160604051458.GA3149@glandium.org> (raw)
In-Reply-To: <xmqqvb1pzvfu.fsf@gitster.mtv.corp.google.com>

On Fri, Jun 03, 2016 at 04:47:33PM -0700, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
> 
> > In fact, the parser doesn't even reject the one that is considered
> > invalid (the first).
> 
> My question was what the desired behaviour is, and if your "fix"
> gives us that desired outcome.

>From my POV, the desired outcome from this patch series is that there is
no change of behavior, and Torsten's fix makes
git://[example.com:123]:/path/to/repo urls handled the same before and
after the patch series.

Whether that's the desired behavior is another topic, that we can,
IMHO, leave for later.

Mike

  reply	other threads:[~2016-06-04  5:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02 22:52 What's cooking in git.git (Jun 2016, #01; Thu, 2) Junio C Hamano
2016-06-02 23:13 ` Mike Hommey
2016-06-03  5:07   ` Torsten Bögershausen
2016-06-03 15:59     ` Junio C Hamano
2016-06-03 23:26     ` Mike Hommey
2016-06-03 23:47       ` Junio C Hamano
2016-06-04  5:14         ` Mike Hommey [this message]
2016-06-04 14:51           ` Torsten Bögershausen
2016-06-04 21:46             ` Mike Hommey
2016-06-04 16:24           ` Junio C Hamano
2016-06-05  9:29             ` Torsten Bögershausen
2016-06-05 11:09             ` [PATCH v1 1/1] connect: [host:port] is lagacy for ssh tboegi
2016-06-05 18:56               ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160604051458.GA3149@glandium.org \
    --to=mh@glandium.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).