git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/5] A bit more "attributes"
Date: Wed,  8 Jun 2016 15:58:13 -0700	[thread overview]
Message-ID: <20160608225818.726-1-gitster@pobox.com> (raw)

The whole jc/attr topic is now depended on Stefan's "pathspec label"
topic, both of which are in 'next' and cannot be rewound until the
next cycle.  These five patches are to continue my recent
"attributes" work while the tree is in frozen state.

A few central data structures, namely "attr_stack" that keeps track
of the attributes read from the .gitattributes files in the
directory hierarchy of interest and "check_all_attr[]" that keeps
track of the state of the attributes for the path being checked, are
implemented as file-scope global singletons that belong to the
attribute subsystem ("attr.c").  The envisioned endgame is to make
them into per "struct git_attr_check" instance, so that the entire
system can have multiple "directory hierarchy of interest" and "path
being checked", i.e. allow multiple threads to keep their own
"git_attr_check" and to use the attribute system simultaneously.

To further that plan, the first two patches pass the check[]
structure further down the callchain, and the last two patches
remove a hack that prevented check[] from being passed in one corner
case and always pass it down the callchain.

Junio C Hamano (5):
  attr.c: add push_stack() helper
  attr.c: pass struct git_attr_check down the callchain
  fixup! d5ad6c13
  attr.c: correct ugly hack for git_all_attrs()
  attr.c: always pass check[] to collect_some_attrs()

 attr.c | 143 +++++++++++++++++++++++++++++++++--------------------------------
 attr.h |   2 +-
 2 files changed, 74 insertions(+), 71 deletions(-)

-- 
2.9.0-rc2-262-g9161bbf

             reply	other threads:[~2016-06-08 22:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 22:58 Junio C Hamano [this message]
2016-06-08 22:58 ` [PATCH 1/5] attr.c: add push_stack() helper Junio C Hamano
2016-06-08 23:43   ` Stefan Beller
2016-06-09  0:15     ` Junio C Hamano
2016-06-08 22:58 ` [PATCH 2/5] attr.c: pass struct git_attr_check down the callchain Junio C Hamano
2016-06-08 23:54   ` Stefan Beller
2016-06-08 22:58 ` [PATCH 3/5] fixup! d5ad6c13 Junio C Hamano
2016-06-09  0:00   ` Stefan Beller
2016-06-09  0:10     ` Junio C Hamano
2016-06-08 22:58 ` [PATCH 4/5] attr.c: correct ugly hack for git_all_attrs() Junio C Hamano
2016-06-08 22:58 ` [PATCH 5/5] attr.c: always pass check[] to collect_some_attrs() Junio C Hamano
2016-06-09  0:25   ` Stefan Beller
2016-06-09 18:15     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160608225818.726-1-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).