From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jacob Keller <jacob.keller@gmail.com>,
Stefan Beller <sbeller@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] diff: disable compaction heuristic for now
Date: Fri, 10 Jun 2016 16:53:57 -0400 [thread overview]
Message-ID: <20160610205357.GA22470@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqoa78epmt.fsf_-_@gitster.mtv.corp.google.com>
On Fri, Jun 10, 2016 at 01:48:58PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > We probably want a patch to the release notes to note that it's not on
> > by default. And we may want to advertise the experimental knob so
> > that people actually try it (otherwise we won't get feedback from the
> > masses).
>
> OK, I think that is sensible. The interdiff is not a strict
> reversion of 77085a61 (diff: undocument the compaction heuristic
> knobs for experimentation, 2016-05-02) but stresses that the
> feature is off by default and is experimental.
Looks good to me. Do we want to include in "experimental" that the
option and command-line flag might go away in the future? I think
probably not. I do not mind supporting this forever (it _has_ shown its
usefulness, so I don't think it is any worse to maintain going forward
than things like --patience, which people can tweak if their diff looks
uglier than they would like).
-Peff
next prev parent reply other threads:[~2016-06-10 20:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 7:50 [BUG-ish] diff compaction heuristic false positive Jeff King
2016-06-10 8:31 ` Jeff King
2016-06-10 15:56 ` Junio C Hamano
2016-06-10 16:25 ` Stefan Beller
2016-06-10 16:29 ` Jacob Keller
2016-06-10 18:13 ` Re* " Junio C Hamano
2016-06-10 18:21 ` Stefan Beller
2016-06-10 20:30 ` Jeff King
2016-06-10 20:48 ` [PATCH v2] diff: disable compaction heuristic for now Junio C Hamano
2016-06-10 20:53 ` Jeff King [this message]
2016-06-10 20:55 ` Junio C Hamano
2016-06-10 21:05 ` Jeff King
2016-06-10 21:46 ` Junio C Hamano
2016-06-10 8:31 ` [BUG-ish] diff compaction heuristic false positive Michael Haggerty
2016-06-10 8:41 ` Jeff King
2016-06-10 11:00 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610205357.GA22470@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).