From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] lib-httpd.sh: print error.log on error
Date: Mon, 13 Jun 2016 13:08:33 -0400 [thread overview]
Message-ID: <20160613170832.GA7283@sigill.intra.peff.net> (raw)
In-Reply-To: <20160613123509.22412-1-pclouds@gmail.com>
On Mon, Jun 13, 2016 at 07:35:09PM +0700, Nguyễn Thái Ngọc Duy wrote:
> Failure to bring up httpd for testing is not considered an error, so the
> trash directory, which contains this error.log file, is removed and we
> don't know what made httpd fail to start. Improve the situation a bit,
> print error.log but only in verbose mode.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Looks good to me. Thanks.
-Peff
prev parent reply other threads:[~2016-06-13 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 10:41 [PATCH] lib-httpd.sh: print error.log on error Nguyễn Thái Ngọc Duy
2016-06-12 12:59 ` Jeff King
2016-06-13 11:40 ` Duy Nguyen
2016-06-13 11:56 ` Jeff King
2016-06-13 12:35 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2016-06-13 17:08 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613170832.GA7283@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).