From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2016, #04; Tue, 14)
Date: Thu, 16 Jun 2016 13:16:30 +0900 [thread overview]
Message-ID: <20160616041630.GA32045@glandium.org> (raw)
In-Reply-To: <xmqqd1ni716g.fsf@gitster.mtv.corp.google.com>
On Wed, Jun 15, 2016 at 11:32:39AM -0700, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > On Tue, Jun 14, 2016 at 03:08:04PM -0700, Junio C Hamano wrote:
>
> >> * mh/connect (2016-06-06) 10 commits
> >> - connect: [host:port] is legacy for ssh
> >> ...
> >> - connect: document why we sometimes call get_port after get_host_and_port
> >>
> >> Ok, folks, is everybody happy with this version?
> >
> > $gmane/296609
> > $gmane/296610
>
> Oh, I have seen these, and I know you two are happy.
>
> But I am having a hard time coming up with a few-line summary for
> this topic. I can write the beginning part, i.e. "Git-URL parsing
> routine has been rewritten", but the concluding part of the sentence
> cannot be "... has been rewritten for no good reason." if I were to
> mark the topic as "Will merge to 'next'". The best I can come up
> with is "... has been rewritten (hopefully) without changing the
> benaviour.", but that is not a strong-enough justificaiton to make
> the change to the codebase, either.
>
> In short, while the update may not introduce new bugs, why would we
> want to have this change in the first place?
My original motivation was to avoid having to copy code from connect.c
into git-cinnabar, which is what I'm currently doing[1]. Things derailed
a little, and we got ourselves somewhat in the middle of a refactor,
that I'm willing to push a little further (like, refactor things such
that host_end only happens once). My hope is that this makes the code
more maintainable.
Mike
1. https://github.com/glandium/git-cinnabar/blob/master/connect.c
next prev parent reply other threads:[~2016-06-16 4:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 22:08 What's cooking in git.git (Jun 2016, #04; Tue, 14) Junio C Hamano
2016-06-15 2:36 ` Mike Hommey
2016-06-15 18:32 ` Junio C Hamano
2016-06-16 4:16 ` Mike Hommey [this message]
2016-06-15 7:35 ` Elia Pinto
2016-06-16 12:36 ` Jeff King
2016-06-16 21:14 ` Junio C Hamano
2016-06-15 10:12 ` Duy Nguyen
2016-06-15 18:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616041630.GA32045@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).