From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/7] gpg-interface cleanups
Date: Thu, 16 Jun 2016 05:32:48 -0400 [thread overview]
Message-ID: <20160616093248.GA15130@sigill.intra.peff.net> (raw)
This started off with Michael's patch to sign_buffer, which is at the
tip, and then me trying to address the possible deadlocks there and in
verify_signed_buffer. While I was in the area, I took the opportunity to
do a few cleanups.
It's unclear to me whether the deadlocks are possible in practice; see
patch 5 for discussion. My guess is probably not, but the amount of code
to support doing it right is not all that much. But if we don't like it,
we can drop 4-6.
Patch 7 is still authored by Michael, but has been massaged greatly by
me. I'll comment more directly on the changes there.
[1/7]: gpg-interface: use child_process.args
[2/7]: verify_signed_buffer: drop pbuf variable
[3/7]: verify_signed_buffer: use tempfile object
[4/7]: run-command: add pipe_command helper
[5/7]: verify_signed_buffer: use pipe_command
[6/7]: sign_buffer: use pipe_command
[7/7]: gpg-interface: check gpg signature creation status
next reply other threads:[~2016-06-16 9:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 9:32 Jeff King [this message]
2016-06-16 9:33 ` [PATCH 1/7] gpg-interface: use child_process.args Jeff King
2016-06-16 9:34 ` [PATCH 2/7] verify_signed_buffer: drop pbuf variable Jeff King
2016-06-16 9:35 ` [PATCH 3/7] verify_signed_buffer: use tempfile object Jeff King
2016-06-16 9:37 ` [PATCH 4/7] run-command: add pipe_command helper Jeff King
2016-06-17 20:03 ` Eric Sunshine
2016-06-17 23:28 ` Jeff King
2016-06-17 23:31 ` Eric Sunshine
2016-06-16 9:38 ` [PATCH 5/7] verify_signed_buffer: use pipe_command Jeff King
2016-06-16 9:39 ` [PATCH 6/7] sign_buffer: " Jeff King
2016-06-16 9:42 ` [PATCH 7/7] gpg-interface: check gpg signature creation status Jeff King
2016-06-16 18:20 ` [PATCH 0/7] gpg-interface cleanups Junio C Hamano
2016-06-17 9:20 ` Michael J Gruber
2016-06-17 9:21 ` Jeff King
2016-06-17 23:38 ` [PATCH v2 " Jeff King
2016-06-17 23:38 ` [PATCH v2 1/7] gpg-interface: use child_process.args Jeff King
2016-06-17 23:38 ` [PATCH v2 2/7] verify_signed_buffer: drop pbuf variable Jeff King
2016-06-17 23:38 ` [PATCH v2 3/7] verify_signed_buffer: use tempfile object Jeff King
2016-06-17 23:38 ` [PATCH v2 4/7] run-command: add pipe_command helper Jeff King
2016-06-17 23:38 ` [PATCH v2 5/7] verify_signed_buffer: use pipe_command Jeff King
2016-06-17 23:38 ` [PATCH v2 6/7] sign_buffer: " Jeff King
2016-06-17 23:38 ` [PATCH v2 7/7] gpg-interface: check gpg signature creation status Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616093248.GA15130@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).