From: Jeff King <peff@peff.net>
To: Norbert Kiesel <nkiesel@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: unable to pull from remote if commit date is in the future
Date: Mon, 20 Jun 2016 15:46:49 -0400 [thread overview]
Message-ID: <20160620194648.GB3631@sigill.intra.peff.net> (raw)
In-Reply-To: <20160620193928.GA3631@sigill.intra.peff.net>
On Mon, Jun 20, 2016 at 03:39:28PM -0400, Jeff King wrote:
> On Mon, Jun 20, 2016 at 12:05:07PM -0700, Norbert Kiesel wrote:
>
> > Hmm. On closer inspection that commit 23c07cc that github shows with
> > date 2152-06-19 is already in my local branch. I got confused because
> > locally it is shown with a different date: `git log -1 --format='%ci'
> > 23c07cc` shows "2106-02-07 06:28:56 -40643156" which is invalid.
> >
> > My system is running Debian unstable 64bit. Is git using the time
> > rendering methods from the C library (glibc 2.22-12)?
>
> No, git's time code is (mostly) internal routines. Can you show us the
> output of:
>
> git cat-file commit 23c07cc | egrep '^author|committer'
>
> Note also that some interfaces (like "git log", and GitHub) will show
> the author date by default, which might be different than the committer
> date. The "-40643156" timezone definitely looks suspicious, though. I'm
> curious if it is bad handling in the time code, or if the commit has
> corrupt ident lines.
Actually, I just noticed in your earlier message a link to the public
GitHub repository.
So to answer my own questions:
$ git cat-file commit 23c07cc | egrep '^author|committer'
author Sean D'Epagnier <seandepagnier@gmail.com> 5758122296 -40643156
committer Sean D'Epagnier <seandepagnier@gmail.com> 5758122296 -40643156
Yes, the timezone really is that ridiculous value. No, the author and
committer aren't different. According to GNU date, the correct timestamp
is actually in 2152. Offhand, I'd guess that the timestamp exceeding
2^32 is getting converted somewhere inside git to a bogus value, and
that's how we end up with 2106.
-Peff
next prev parent reply other threads:[~2016-06-20 19:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 18:41 unable to pull from remote if commit date is in the future Norbert Kiesel
2016-06-20 18:46 ` Stefan Beller
2016-06-20 19:05 ` Norbert Kiesel
2016-06-20 19:39 ` Jeff King
2016-06-20 19:45 ` Norbert Kiesel
2016-06-20 19:46 ` Jeff King [this message]
2016-06-20 20:00 ` Jeff King
2016-06-20 21:09 ` [PATCH 0/3] fix local_tzoffset with far-in-future dates Jeff King
2016-06-20 21:10 ` [PATCH 1/3] t0006: rename test-date's "show" to "relative" Jeff King
2016-06-20 21:11 ` [PATCH 2/3] t0006: test various date formats Jeff King
2016-06-20 21:14 ` [PATCH 3/3] local_tzoffset: detect errors from tm_to_time_t Jeff King
2016-06-20 22:11 ` [PATCH 0/3] fix local_tzoffset with far-in-future dates Junio C Hamano
2016-06-20 22:21 ` Jeff King
2016-06-21 6:37 ` Norbert Kiesel
2016-06-21 12:18 ` Jeff King
2016-06-20 19:49 ` unable to pull from remote if commit date is in the future Eric Deplagne
2016-06-20 20:02 ` Jeff King
2016-06-20 20:27 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620194648.GB3631@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nkiesel@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).