git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Use docker for _some_ testing?
Date: Wed, 22 Jun 2016 15:59:32 -0400	[thread overview]
Message-ID: <20160622195932.GC1697@sigill.intra.peff.net> (raw)
In-Reply-To: <20160622190154.GA17442@duynguyen>

On Wed, Jun 22, 2016 at 09:01:55PM +0200, Duy Nguyen wrote:

> Which makes me think, could we use something like this to make sure
> people (on Linux) can test more obscure cases? Sometimes there are
> featues that require some dependencies that are not always present on
> the developer's machine (http server is a big one, locales come close
> second, then there will be lmdb and watchman in future...). With this,
> said developer can do a final test run in docker covering as much as
> possible.

Neat idea. This should also cover some other distro-specific issues like
"what's your /bin/sh look like", etc. It's a lighter-weight alternative
to testing alternate distros in a VM.

But I think most of the interesting cases are more exotic than
distro-to-distro. Things like HFS+ normalization, or weird shell
toolchains on proprietary Unixes (but maybe there are docker images for
those systems?).

So I dunno if it would prove that useful for day to day use or not.

> +ROOT="$(realpath $(git rev-parse --show-cdup))"

I tried running this as contrib/docker/run.sh, which complained here,
because --show-cdup is empty.

> +test "$(docker images --format='{{.Repository}}' $IMAGE)" = $IMAGE || \
> +	build_$DISTRO

My docker complained that it doesn't know --format. I guess I might just
have an old one (it's whatever is in Debian unstable, which is 1.8.3).

Not things you need to fix, but just comments for anybody else fiddling
with it.

-Peff

  parent reply	other threads:[~2016-06-22 19:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 19:01 Use docker for _some_ testing? Duy Nguyen
2016-06-22 19:33 ` Junio C Hamano
2016-06-22 19:59 ` Jeff King [this message]
2016-06-23  4:14   ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160622195932.GC1697@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).