From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: preview: What's cooking in git.git (Jun 2016, #10; Tue, 28)
Date: Thu, 30 Jun 2016 02:26:39 -0400 [thread overview]
Message-ID: <20160630062638.GB15380@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1606291345440.12947@virtualbox>
On Wed, Jun 29, 2016 at 01:47:31PM +0200, Johannes Schindelin wrote:
> On Tue, 28 Jun 2016, Junio C Hamano wrote:
>
> > * jk/ansi-color (2016-06-23) 7 commits
> > (merged to 'next' on 2016-06-28 at 354989c)
> > + color: support strike-through attribute
> > + color: support "italic" attribute
> > + color: allow "no-" for negating attributes
> > + color: refactor parse_attr
> > + add skip_prefix_mem helper
> > + doc: refactor description of color format
> > + color: fix max-size comment
> >
> > The output coloring scheme learned two new attributes, italic and
> > strike, in addition to existing bold, reverse, etc.
> >
> > Will merge to 'master'.
>
> Please note that those "colors" do not work on Windows, at least as far as
> I know, I only skimmed the code in set_attr():
>
> https://github.com/git/git/blob/v2.9.0/compat/winansi.c#L175-L314
>
> ... and it looks as if italic is plainly unsupported, and strike-through
> is not handled.
I suspect winansi doesn't handle 256-color or 24-bit color modes either,
and those are also not supported on all terminals. All of the color
output is subject to the user's terminal supporting it. It might be
that we should make a more clear disclaimer in the documentation.
-Peff
prev parent reply other threads:[~2016-06-30 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 23:36 preview: What's cooking in git.git (Jun 2016, #10; Tue, 28) Junio C Hamano
2016-06-29 1:43 ` Jeff King
2016-06-29 2:39 ` Junio C Hamano
2016-06-29 5:41 ` Johannes Sixt
2016-06-30 8:16 ` Jeff King
2016-06-29 11:47 ` Johannes Schindelin
2016-06-29 16:57 ` Junio C Hamano
2016-07-02 7:32 ` Johannes Schindelin
2016-06-30 6:26 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630062638.GB15380@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).