From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@drmicha.warpmail.net, j.cretel@umail.ucc.ie,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH] log: decorate HEAD -> branch with the same color for branch and HEAD
Date: Thu, 30 Jun 2016 18:39:42 +0200 [thread overview]
Message-ID: <20160630163942.8353-1-pclouds@gmail.com> (raw)
Commit 76c61fb (log: decorate HEAD with branch name under
--decorate=full, too - 2015-05-13) adds "HEAD -> branch" decoration to
show current branch vs detached HEAD. The sign of whether HEAD is
detached or not is "->" (vs ", "). It's too subtle for my poor
eyes. If color is used, we can make the branch name's color the same
as HEAD to visually emphasize that it's the current branch.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
For the original discussion of 76c61fb see
http://thread.gmane.org/gmane.comp.version-control.git/263922
log-tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/log-tree.c b/log-tree.c
index 78a5381..440e7cc 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -267,7 +267,7 @@ void format_decorations_extended(struct strbuf *sb,
strbuf_addstr(sb, color_commit);
strbuf_addstr(sb, " -> ");
strbuf_addstr(sb, color_reset);
- strbuf_addstr(sb, decorate_get_color(use_color, current_and_HEAD->type));
+ strbuf_addstr(sb, decorate_get_color(use_color, DECORATION_REF_HEAD));
show_name(sb, current_and_HEAD);
}
strbuf_addstr(sb, color_reset);
--
2.8.2.531.gd073806
next reply other threads:[~2016-06-30 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 16:39 Nguyễn Thái Ngọc Duy [this message]
2016-06-30 16:43 ` [PATCH] log: decorate HEAD -> branch with the same color for branch and HEAD Duy Nguyen
2016-07-01 6:31 ` Jeff King
2016-07-01 14:20 ` Michael J Gruber
2016-07-01 15:13 ` Duy Nguyen
2016-07-09 12:49 ` [PATCH v2] log: decorate HEAD -> branch with the same color for arrow " Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630163942.8353-1-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.cretel@umail.ucc.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).