git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Hommey <mh@glandium.org>
To: git@vger.kernel.org
Cc: gitster@pobox.com, spearce@spearce.org, jrnieder@gmail.com
Subject: Re: [PATCH/RFC] fast-import: Keep a fake pack window on the recently written data
Date: Mon, 4 Jul 2016 09:01:36 +0900	[thread overview]
Message-ID: <20160704000135.GA9467@glandium.org> (raw)
In-Reply-To: <20160703234439.8889-1-mh@glandium.org>

On Mon, Jul 04, 2016 at 08:44:39AM +0900, Mike Hommey wrote:
> +		/* Ensure a pack window on the data before that, otherwise,
> +		 * use_pack() may try to create a window that overlaps with
> +		 * this one, and that won't work because it won't be complete. */

In fact, there is still a possibility of this happening after that pack
window in closed when opening windows on other packs.

Mike

  reply	other threads:[~2016-07-04  0:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03 23:44 [PATCH/RFC] fast-import: Keep a fake pack window on the recently written data Mike Hommey
2016-07-04  0:01 ` Mike Hommey [this message]
2016-07-22 22:19 ` Mike Hommey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704000135.GA9467@glandium.org \
    --to=mh@glandium.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).