From: Charles Bailey <charles@hashpling.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: What's cooking in git.git (Jul 2016, #02; Wed, 6)
Date: Thu, 7 Jul 2016 22:34:26 +0100 [thread overview]
Message-ID: <20160707213426.GA20572@hashpling.org> (raw)
In-Reply-To: <xmqqshvlnnzb.fsf@gitster.mtv.corp.google.com>
On Thu, Jul 07, 2016 at 02:21:28PM -0700, Junio C Hamano wrote:
> Charles Bailey <charles@hashpling.org> writes:
>
> > I just wanted to clarify what was actually fixed. The actual bug that
> > was reported and fixed was the fact that 'git grep' (without --cached)
> > wasn't searching the contents of files in the working tree if the index
> > entry had the "intent to add" bit set.
>
> Ouch, you are absolutely right.
>
> Git does not know what the contents in the index should be for a
> path added with "git add -N" yet, so "git grep --cached" should not
> show hits (or show lack of hits, with -L) in such a path, but that
> logic does not apply to "git grep", i.e. searching in the working
> tree files. But we did so by mistake, which has been corrected.
>
> perhaps?
Yes, that reads like an accurate summary to me.
prev parent reply other threads:[~2016-07-07 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 21:39 What's cooking in git.git (Jul 2016, #02; Wed, 6) Junio C Hamano
2016-07-07 20:40 ` Charles Bailey
2016-07-07 21:21 ` Junio C Hamano
2016-07-07 21:34 ` Charles Bailey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707213426.GA20572@hashpling.org \
--to=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).