From: Jeff King <peff@peff.net>
To: Parker Moore <parkrmoore@gmail.com>
Cc: git@vger.kernel.org, cranger@google.com,
Shawn Pearce <spearce@spearce.org>
Subject: Re: [PATCH] contrib/persistent-https: update ldflags syntax for Go 1.7+
Date: Sat, 16 Jul 2016 01:18:01 -0400 [thread overview]
Message-ID: <20160716051800.GA2845@sigill.intra.peff.net> (raw)
In-Reply-To: <CAOiOGAcqsdMD0j_ZUdvvGiA9Bd6bUmfvxziN06Rw81f_pO7cgg@mail.gmail.com>
[+cc Shawn, who participated in the original discussion, as I don't
think Colby really works on git any more]
On Fri, Jul 15, 2016 at 01:44:14PM -0700, Parker Moore wrote:
> From: Parker Moore <parkrmoore@gmail.com>
>
> This fixes contrib/persistent-https builds for Go v1.7+ and is
> compatible with Go v1.5+.
>
> Running `make all` in `contrib/persistent-https` results in a failure
> on Go 1.7 and above.
>
> Specifically, the error is:
>
> go build -o git-remote-persistent-https \
> -ldflags "-X main._BUILD_EMBED_LABEL 1468613136"
> # _/Users/parkr/github/git/contrib/persistent-https
> /usr/local/Cellar/go/1.7rc1/libexec/pkg/tool/darwin_amd64/link: -X
> flag requires argument of the form importpath.name=value
> make: *** [git-remote-persistent-https] Error 2
>
> This `name=value` syntax for the -X flag was introduced in Go v1.5
> (released Aug 19, 2015):
>
> - release notes: https://golang.org/doc/go1.5#link
> - commit: https://github.com/golang/go/commit/12795c02f3d6fc54ece09a86e70aaa40a94d5131
>
> In Go v1.7, support for the old syntax was removed:
>
> - release notes: https://tip.golang.org/doc/go1.7#compiler
> - commit: https://github.com/golang/go/commit/51b624e6a29b135ce0fadb22b678acf4998ff16f
>
> This patch includes the `=` to fix builds with Go v1.7+.
With the disclaimer that I have very little experience with Go, this
seems like a good, well-explained change. My only question would be
whether people still use pre-v1.5 versions of Go, since it sounds like
this would adversely affect them if they do. (If it does, it seems the
Go people did not give a very good deprecation period for the syntax
change, if people are using both the pre-new-syntax and post-old-syntax
versions simultaneously). I'm not sure what the alternative is, beyond
perhaps checking the version of Go dynamically in the Makefile.
-Peff
next prev parent reply other threads:[~2016-07-16 5:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 20:44 [PATCH] contrib/persistent-https: update ldflags syntax for Go 1.7+ Parker Moore
2016-07-16 5:18 ` Jeff King [this message]
2016-07-18 20:36 ` Junio C Hamano
2016-07-19 4:32 ` Parker Moore
2016-07-19 4:49 ` Shawn Pearce
2016-07-19 17:04 ` Junio C Hamano
2016-07-19 23:32 ` Parker Moore
2016-07-20 19:21 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2016-07-21 0:58 Parker Moore
2016-07-22 17:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716051800.GA2845@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=cranger@google.com \
--cc=git@vger.kernel.org \
--cc=parkrmoore@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).