From: Josh Triplett <josh@joshtriplett.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: format-patch with pager.format-patch=true gets very confused
Date: Sun, 17 Jul 2016 12:20:19 -0700 [thread overview]
Message-ID: <20160717192019.GA29262@x> (raw)
In-Reply-To: <alpine.DEB.2.20.1607171438030.28832@virtualbox>
On Sun, Jul 17, 2016 at 02:41:48PM +0200, Johannes Schindelin wrote:
> Hi Josh,
>
> On Sat, 16 Jul 2016, Josh Triplett wrote:
>
> > git-config(1) documents the ability to enable or disable the pager (or
> > set a command-specific pager) for any command by setting
> > pager.<cmd>=true. For most commands, this seems to work as expected.
> > However, setting pager.format-patch=true (or setting it to any specific
> > pager) breaks badly: the pager spawns, with no output in it, and the
> > pager doesn't respond to keystrokes (which makes it difficult to quit).
> >
> > I think this may occur because format-patch's "reopen_stdout" interacts
> > badly with the pager.
> >
> > I think it makes sense for "format-patch --stdout" to respect
> > pager.format-patch, but for format-patch *without* stdout to ignore
> > pager.* and *never* spawn a pager, given that its only output (the list
> > of patch files) goes to "realstdout".
>
> As per http://article.gmane.org/gmane.comp.version-control.git/299451,
> the `js/log-to-diffopt-file` patch series will be merged to `master` soon.
> This patch series avoids the reopen() altogether and should fix the
> problem you experience.
>
> Since it is already in `next`, it should be relatively easy for you to
> build and confirm. Would you kindly do that?
I can confirm that that fixes the problem. Thanks!
- Josh Triplett
prev parent reply other threads:[~2016-07-17 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 2:56 format-patch with pager.format-patch=true gets very confused Josh Triplett
2016-07-17 12:41 ` Johannes Schindelin
2016-07-17 19:20 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160717192019.GA29262@x \
--to=josh@joshtriplett.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).