From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 57044203E3 for ; Mon, 25 Jul 2016 20:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbcGYUdT (ORCPT ); Mon, 25 Jul 2016 16:33:19 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:60084 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835AbcGYUdR (ORCPT ); Mon, 25 Jul 2016 16:33:17 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id F1C77203E2; Mon, 25 Jul 2016 20:33:16 +0000 (UTC) Date: Mon, 25 Jul 2016 20:33:16 +0000 From: Eric Wong To: Junio C Hamano Cc: Duy Nguyen , git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: <20160725203316.GA32053@starla> References: <20160725162125.15734-1-pclouds@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano wrote: > Duy Nguyen writes: > > > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: > >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote: > >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has > >>> been removed at least on FreeBSD 10.3. See [1] for more information. > >>> > >>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c Ah, I missed that. I guess that explains why nobody complained about the problem sooner. > >>> Signed-off-by: Nguyễn Thái Ngọc Duy > >>> --- > >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real > >>> fbsd. > >> > >> Thanks; and we know that older (but not too old that we no longer care about) > >> FreeBSD all have /usr/local/bin/perl? > > > > I'm no fbsd expert but from the first sentence in [1] "Perl has been > > removed from base more than ten years ago..." I would assume it meant > > "... removed from base, _to_ ports system" which means /usr/local for > > all package installation (for ten years for perl). So I think we are > > good. > > I guess we didn't follow through > > http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/ > > and allowed the thread to drift into a tangent? +Cc Dscho I've been meaning to followup on that, but had connectivity problems to my VM last week. I still prefer we use numeric comparisons for version numbers since numbers are... numeric. IOW, I prefer we go with my original patch.