git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	git@vger.kernel.org
Subject: [PATCH 0/2] format-patch: Transition the default to --from to avoid spoofed mails
Date: Sat, 30 Jul 2016 02:41:44 -0700	[thread overview]
Message-ID: <20160730094144.ajtkdveuhpf5hmvg@x> (raw)
In-Reply-To: <20160730055717.i7rtgswbi6q2cdsg@x>

As discussed, this patch series allows transitioning the default
behavior of format-patch to --from, to avoid spoofing mails when
formatting commits not written by the user.

The first patch introduces the format.from option to set the default
value of format-patch --from.  This patch doesn't change the default
behavior of format-patch, so it can go in without any transition.

The second patch changes the default to --from.  If you'd like to delay
this patch for a release and mention the planned change in the release
notes, let me know and I'll provide text for the release notes; if you
don't think this needs a transition period, you can go ahead and apply
the second patch.

Josh Triplett (2):
  format-patch: Add a config option format.from to set the default for --from
  format-patch: Default to --from

 Documentation/config.txt               | 10 ++++-
 builtin/log.c                          | 14 +++++-
 contrib/completion/git-completion.bash |  1 +-
 t/t4014-format-patch.sh                | 68 +++++++++++++++++++++++++--
 4 files changed, 89 insertions(+), 4 deletions(-)

-- 
git-series 0.8.7

  reply	other threads:[~2016-07-30  9:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 21:11 [RFC] git-format-patch: default to --from to avoid spoofed mails? Josh Triplett
2016-07-28 21:37 ` Junio C Hamano
2016-07-28 21:56   ` Jeff King
2016-07-28 22:14     ` Junio C Hamano
2016-07-28 23:53       ` Josh Triplett
2016-07-29  0:17         ` Jeff King
2016-07-29  0:16       ` Jeff King
2016-07-29  2:08         ` Josh Triplett
2016-07-29 22:58           ` Jeff King
2016-07-30  4:50             ` Josh Triplett
2016-07-30  5:47               ` Jeff King
2016-07-30  5:57                 ` Josh Triplett
2016-07-30  9:41                   ` Josh Triplett [this message]
2016-08-01 17:35                 ` Junio C Hamano
2016-08-01 17:43                   ` Jeff King
2016-08-01 18:59                     ` Junio C Hamano
2016-07-29  0:04     ` Josh Triplett
2016-07-29  0:05   ` Josh Triplett
2016-07-29 16:56     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160730094144.ajtkdveuhpf5hmvg@x \
    --to=josh@joshtriplett.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).