git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>, "Kyle J. McKay" <mackyle@gmail.com>,
	git@vger.kernel.org,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH 1/1 v2] pager: move pager-specific setup into the build
Date: Wed, 3 Aug 2016 21:08:21 +0000	[thread overview]
Message-ID: <20160803210821.GA17510@whir> (raw)
In-Reply-To: <xmqq4m718tay.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> wrote:
> All bugs are from my original, I think.  Here is a proposed squash.

Thanks, I'll take the git-sh-setup changes.

I actually just rewrote setup_pager_env using split_cmdline and
eliminated all the scary (to me) pointer arithmetic and avoided
strbuf, too.

Unfortunately, my Internet connection on that machine dropped
before I could finish testing and pushing :<

This was also the machine running http://czquwvybam4bgbro.onion/git/ :<

  reply	other threads:[~2016-08-03 21:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01  1:05 [PATCH 0/2] add PAGER_ENV to build and core.pagerEnv to config Eric Wong
2016-08-01  1:05 ` [PATCH 1/2] pager: move pager-specific setup into the build Eric Wong
2016-08-01  1:43   ` brian m. carlson
2016-08-01  7:00     ` Eric Wong
2016-08-01  8:57       ` Jakub Narębski
2016-08-01 10:40         ` brian m. carlson
2016-08-01 17:24     ` Jeff King
2016-08-01 18:07       ` Junio C Hamano
2016-08-01 17:46   ` Duy Nguyen
2016-08-01 17:52     ` Jeff King
2016-08-01 18:01       ` Duy Nguyen
2016-08-01 18:07         ` Jeff King
2016-08-01  1:05 ` [PATCH 2/2] pager: implement core.pagerEnv in config Eric Wong
2016-08-01 17:28   ` Jeff King
2016-08-01 21:49 ` [PATCH 0/1 v2] add PAGER_ENV to build Eric Wong
2016-08-01 21:49   ` [PATCH 1/1 v2] pager: move pager-specific setup into the build Eric Wong
2016-08-01 23:03     ` Junio C Hamano
2016-08-01 23:46       ` Jeff King
2016-08-02 21:14         ` Junio C Hamano
2016-08-01 23:56       ` Eric Wong
2016-08-02 21:15         ` Junio C Hamano
2016-08-03 16:19     ` Jeff King
2016-08-03 20:57       ` Junio C Hamano
2016-08-03 21:08         ` Eric Wong [this message]
2016-08-03 21:15           ` Junio C Hamano
2016-08-04  3:43             ` [PATCH v3] " Eric Wong
2016-08-04  5:34               ` Jeff King
2016-08-04 11:34                 ` Eric Wong
2016-08-04 17:53                   ` Jeff King
2016-08-04 11:40               ` [PATCH v4] " Eric Wong
2016-08-03 21:09         ` [PATCH 1/1 v2] " Jeff King
2016-08-01 21:59   ` [PATCH 0/1 v2] add PAGER_ENV to build Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160803210821.GA17510@whir \
    --to=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=mackyle@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).