* [PATCH] xdiff: remove unneeded declarations
@ 2016-09-03 3:16 Stefan Beller
2016-09-06 17:57 ` Stefan Beller
2016-09-07 16:40 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Beller @ 2016-09-03 3:16 UTC (permalink / raw)
To: gitster; +Cc: git, Stefan Beller
Signed-off-by: Stefan Beller <sbeller@google.com>
---
xdiff/xemit.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/xdiff/xemit.c b/xdiff/xemit.c
index 49aa16f..b52b4b9 100644
--- a/xdiff/xemit.c
+++ b/xdiff/xemit.c
@@ -22,15 +22,6 @@
#include "xinclude.h"
-
-
-
-static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
-static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
-
-
-
-
static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
*rec = xdf->recs[ri]->ptr;
--
2.10.0.rc2.22.g25cb54d.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xdiff: remove unneeded declarations
2016-09-03 3:16 [PATCH] xdiff: remove unneeded declarations Stefan Beller
@ 2016-09-06 17:57 ` Stefan Beller
2016-09-07 16:40 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Beller @ 2016-09-06 17:57 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git@vger.kernel.org, Stefan Beller
On Fri, Sep 2, 2016 at 8:16 PM, Stefan Beller <sbeller@google.com> wrote:
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> xdiff/xemit.c | 9 ---------
> 1 file changed, 9 deletions(-)
Despite the moved coloring patch moving into a different direction, I
think this is still
an improvement to the code.
Thanks,
Stefan
>
> diff --git a/xdiff/xemit.c b/xdiff/xemit.c
> index 49aa16f..b52b4b9 100644
> --- a/xdiff/xemit.c
> +++ b/xdiff/xemit.c
> @@ -22,15 +22,6 @@
>
> #include "xinclude.h"
>
> -
> -
> -
> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
> -
> -
> -
> -
> static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
>
> *rec = xdf->recs[ri]->ptr;
> --
> 2.10.0.rc2.22.g25cb54d.dirty
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xdiff: remove unneeded declarations
2016-09-03 3:16 [PATCH] xdiff: remove unneeded declarations Stefan Beller
2016-09-06 17:57 ` Stefan Beller
@ 2016-09-07 16:40 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2016-09-07 16:40 UTC (permalink / raw)
To: Stefan Beller; +Cc: git
Stefan Beller <sbeller@google.com> writes:
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> xdiff/xemit.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/xdiff/xemit.c b/xdiff/xemit.c
> index 49aa16f..b52b4b9 100644
> --- a/xdiff/xemit.c
> +++ b/xdiff/xemit.c
> @@ -22,15 +22,6 @@
>
> #include "xinclude.h"
>
> -
> -
> -
> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
> -
> -
> -
> -
> static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
>
> *rec = xdf->recs[ri]->ptr;
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-07 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-03 3:16 [PATCH] xdiff: remove unneeded declarations Stefan Beller
2016-09-06 17:57 ` Stefan Beller
2016-09-07 16:40 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).