git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] send-email: use sanitized address for cc
@ 2016-09-07  6:57 changbin.du
  0 siblings, 0 replies; only message in thread
From: changbin.du @ 2016-09-07  6:57 UTC (permalink / raw)
  To: gitster; +Cc: git, Du, Changbin

From: "Du, Changbin" <changbin.du@gmail.com>

Some username in the email address may include a ','. In this case,
we need quoting the username field so it will not be parsed as two
single addresses by Mail::Address->parse().

For example, my eamil address "Du, Changbin <changbin.du@gmail.com>"
can be parsed as two addresses "Du" and "Changbin <changbin.du@gmail.com>"
if username is not quoted. ("Du, Changbin" is a legal format of signature
in Chinese)

The sanitized address can be used because quote is added automactically.

Signed-off-by: Du, Changbin <changbin.du@gmail.com>
---
 git-send-email.perl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 6958785..6ec189e 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1554,9 +1554,9 @@ foreach my $t (@files) {
 				next if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;
 				next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;
 			}
-			push @cc, $c;
+			push @cc, $sc;
 			printf("(body) Adding cc: %s from line '%s'\n",
-				$c, $_) unless $quiet;
+				$sc, $_) unless $quiet;
 		}
 	}
 	close $fh;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-09-07  7:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-07  6:57 [PATCH] send-email: use sanitized address for cc changbin.du

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).