From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Move format-patch base commit and prerequisites before email signature
Date: Fri, 9 Sep 2016 14:00:41 -0700 [thread overview]
Message-ID: <20160909210040.zlsczhcotrxnu4e4@x> (raw)
In-Reply-To: <xmqqpoocajbb.fsf@gitster.mtv.corp.google.com>
On Fri, Sep 09, 2016 at 01:51:04PM -0700, Junio C Hamano wrote:
> Josh Triplett <josh@joshtriplett.org> writes:
>
> > On Fri, Sep 09, 2016 at 12:41:56PM -0700, Junio C Hamano wrote:
> >> So here is a suggested replacement. I notice that in the MIME case,
> >> we do not leave any blank line between the last line of the patch
> >> and the baseinfo, which makes it look a bit strange, e.g. output of
> >> "format-patch --attach=mimemime -1" may end like this:
> >>
> >> + test_write_lines 1 2 >expect &&
> >> + test_cmp expect actual
> >> +'
> >> +
> >> test_expect_success 'format-patch --pretty=mboxrd' '
> >> sp=" " &&
> >> cat >msg <<-INPUT_END &&
> >> base-commit: 6ebdac1bab966b720d776aa43ca188fe378b1f4b
> >>
> >> --------------mimemime--
> >>
> >> We may want to tweak it a bit further.
> >> ...
> >
> > Looks good to me.
>
> Thanks.
>
> Do you mean that the base information that appears immediately after
> the patch text (either for MIME case or plain-text) does not bother
> you, though?
Sorry, I should have clarified that further. I meant that the
additional tests looked good to me.
As it turns out, the patch I used to test this on happened to have a
blank line as the last line of context before the base-commit line, so
I'd overlooked this in the non-MIME case. The issue you mentioned does
apply to both the MIME and non-MIME cases, and I agree that it needs
fixing. It doesn't seem like a functional issue, but aesthetically it
doesn't look good.
Do you plan to make that change to print an additional blank line
(likely inside print_bases), or should I?
next prev parent reply other threads:[~2016-09-09 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 1:12 [PATCH] Move format-patch base commit and prerequisites before email signature Josh Triplett
2016-09-08 18:34 ` Junio C Hamano
2016-09-08 18:54 ` Josh Triplett
2016-09-08 19:11 ` Junio C Hamano
2016-09-08 20:08 ` Jeff King
2016-09-08 21:24 ` Junio C Hamano
2016-09-09 19:41 ` Junio C Hamano
2016-09-09 20:07 ` Josh Triplett
2016-09-09 20:51 ` Junio C Hamano
2016-09-09 21:00 ` Josh Triplett [this message]
2016-09-09 21:16 ` Junio C Hamano
2016-09-14 22:57 ` Junio C Hamano
2016-09-14 23:52 ` Josh Triplett
2016-09-15 17:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909210040.zlsczhcotrxnu4e4@x \
--to=josh@joshtriplett.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).