From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Turner <dturner@twosigma.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/3] tree-walk: be more specific about corrupt tree errors
Date: Tue, 27 Sep 2016 00:53:58 -0400 [thread overview]
Message-ID: <20160927045358.wledqitv4qaqmacl@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqtwd2ng8k.fsf@gitster.mtv.corp.google.com>
On Mon, Sep 26, 2016 at 09:01:15PM -0700, Junio C Hamano wrote:
> > 5 files changed, 21 insertions(+), 7 deletions(-)
> > create mode 100644 t/t1007/.gitattributes
> > create mode 100644 t/t1007/tree-with-empty-filename
> > create mode 100644 t/t1007/tree-with-malformed-mode
>
> I hate to report this, but this alone, or together with 2/2, when
> merged to 'pu', I cannot get them to pass the tests in my automated
> integration tests, even though they seem to pass when the problematic
> tests are run manually. I do not see offhand anything suspicious
> (like something that may be racy) in these two patches but I haven't
> figured out where it goes wrong.
>
> If somebody manages to find breakages in today's 'pu', please (1) do
> not be too alarmed, and (2) help figure out where things are broken.
I think the problem is just that they refer to t/t1450 (and t1007) from
the trash directory as "../t1450". That breaks when the test is run with
"--root" (and I imagine that like me, you have --root as part of your
automated tests but do not bother with it when doing a one-off run).
-Peff
prev parent reply other threads:[~2016-09-27 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 0:11 [PATCH 1/3] tree-walk: be more specific about corrupt tree errors David Turner
2016-09-27 0:11 ` [PATCH 2/3] fsck: handle bad trees like other errors David Turner
2016-09-27 0:11 ` [PATCH 3/3] add David Turner's Two Sigma address David Turner
2016-09-27 0:13 ` David Turner
2016-09-27 4:01 ` [PATCH 1/3] tree-walk: be more specific about corrupt tree errors Junio C Hamano
2016-09-27 4:53 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927045358.wledqitv4qaqmacl@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).