From: Jeff King <peff@peff.net>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] xdiff: rename "struct group" to "struct xdlgroup"
Date: Tue, 27 Sep 2016 15:21:48 -0400 [thread overview]
Message-ID: <20160927192147.k2borko6ryxfx2gf@sigill.intra.peff.net> (raw)
In-Reply-To: <9fb14a41-00b3-f8d1-d8d2-8aa41261492e@alum.mit.edu>
On Tue, Sep 27, 2016 at 03:18:02PM +0200, Michael Haggerty wrote:
> > Let's resolve by giving the xdiff variant a scoped name,
> > which is closer to other xdiff types anyway (e.g.,
> > xdlfile_t, though note that xdiff is fond if typedefs when
> > Git usually is not).
>
> Makes sense to me. I didn't try to adhere to xdiff conventions too
> tightly because I don't think that project is alive anymore, so I don't
> expect we'll be upstreaming anything [1]. But this change definitely
> makes sense.
Yeah, TBH I don't really care about following xdiff coding conventions.
They're pretty far from our own, and at this point I think xdiff is
basically just an imported part of our code base. Mostly my rationale
was that it's not too terribly out of place to give it an "xdl" name,
and it happens to solve my other problem, too. :)
> [1] Though I've since learned that libgit2 also bases their diff code on
> xdiff, so if we avoid changing things gratuitously there is more chance
> that our two projects can benefit from each other's improvements
> whenever they are also licensed compatibly.
I'd agree on not changing things gratuitously.
-Peff
next prev parent reply other threads:[~2016-09-27 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 4:37 [PATCH] xdiff: rename "struct group" to "struct xdlgroup" Jeff King
2016-09-27 13:18 ` Michael Haggerty
2016-09-27 19:21 ` Jeff King [this message]
2016-09-27 16:22 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927192147.k2borko6ryxfx2gf@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).