From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6816C20986 for ; Tue, 4 Oct 2016 21:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752268AbcJDVAT (ORCPT ); Tue, 4 Oct 2016 17:00:19 -0400 Received: from cloud.peff.net ([104.130.231.41]:52382 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957AbcJDVAS (ORCPT ); Tue, 4 Oct 2016 17:00:18 -0400 Received: (qmail 19295 invoked by uid 109); 4 Oct 2016 21:00:18 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Tue, 04 Oct 2016 21:00:18 +0000 Received: (qmail 10195 invoked by uid 111); 4 Oct 2016 21:00:35 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Tue, 04 Oct 2016 17:00:35 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 04 Oct 2016 17:00:15 -0400 Date: Tue, 4 Oct 2016 17:00:15 -0400 From: Jeff King To: Stefan Beller Cc: Jacob Keller , Git mailing list , =?utf-8?B?UmVuw6k=?= Scharfe Subject: Re: [PATCH 06/18] t5613: clarify "too deep" recursion tests Message-ID: <20161004210015.myvb6pjs6gmlv4jr@sigill.intra.peff.net> References: <20161003203321.rj5jepviwo57uhqw@sigill.intra.peff.net> <20161003203412.bekizvlqtg4ls5fb@sigill.intra.peff.net> <20161004134853.x3zq33ywyyzgbwsy@sigill.intra.peff.net> <20161004204933.ygfhoy24g6psyf6h@sigill.intra.peff.net> <20161004205510.6bhisw7ixbgcvvwn@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 04, 2016 at 01:58:54PM -0700, Stefan Beller wrote: > On Tue, Oct 4, 2016 at 1:55 PM, Jeff King wrote: > > On Tue, Oct 04, 2016 at 01:52:19PM -0700, Jacob Keller wrote: > > > >> >> >> > +# Note: These tests depend on the hard-coded value of 5 as "too deep". We start > >> >> >> > +# the depth at 0 and count links, not repositories, so in a chain like: > >> >> >> > +# > >> >> >> > +# A -> B -> C -> D -> E -> F -> G -> H > >> >> >> > +# 0 1 2 3 4 5 6 > >> >> >> > +# > >> [...] > >> > No, we count links, not repositories. So the "A->B" link is "0", "B->C" > >> > is "1", and so on. > >> > >> If you need to re-roll for some other reason I would add some spaces > >> around the numbers so they line up better with the links so that this > >> becomes more clear. > > > > Hmm. Now I am puzzled, because I _did_ line up them specifically to make > > this clear. I put the numbers under the ">" of the arrow. Did I screw up > > the spacing somehow so that isn't how they look to you? Or are you just > > saying you would prefer them under the "-" of the arrow? > > > > -Peff > > Input from a self-claimed design expert for ASCII art. ;) > What about this? > > # A -0-> B -1-> C -2-> ... > > (Double space between letter and arrow, number included in the arrow) I actually find that quite confusing, as it looks like "-1", "-2", etc. This has got to be my favorite bikeshed discussion of all time, though. :) -Peff