git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] submodules: update documentaion for submodule branches
@ 2016-10-19 20:42 Brandon Williams
  2016-10-19 20:45 ` Stefan Beller
  2016-10-19 21:42 ` Junio C Hamano
  0 siblings, 2 replies; 5+ messages in thread
From: Brandon Williams @ 2016-10-19 20:42 UTC (permalink / raw)
  To: git; +Cc: sbeller, Brandon Williams

Update the documentaion for the the special value `.` to indicate that
it signifies that the tracking branch in the submodule should be the
same as the current branch in the superproject.

Signed-off-by: Brandon Williams <bmwill@google.com>
---
 Documentation/git-submodule.txt | 4 +++-
 Documentation/gitmodules.txt    | 7 +++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index bf3bb37..d841573 100644
--- a/Documentation/git-submodule.txt
+++ b/Documentation/git-submodule.txt
@@ -259,7 +259,9 @@ OPTIONS
 --branch::
 	Branch of repository to add as submodule.
 	The name of the branch is recorded as `submodule.<name>.branch` in
-	`.gitmodules` for `update --remote`.
+	`.gitmodules` for `update --remote`.  A special value of `.` is used to
+	indicate that the name of the branch in the submodule should be the
+	same name as the current branch in the current repository.
 
 -f::
 --force::
diff --git a/Documentation/gitmodules.txt b/Documentation/gitmodules.txt
index 10dcc08..8f7c50f 100644
--- a/Documentation/gitmodules.txt
+++ b/Documentation/gitmodules.txt
@@ -50,8 +50,11 @@ submodule.<name>.update::
 
 submodule.<name>.branch::
 	A remote branch name for tracking updates in the upstream submodule.
-	If the option is not specified, it defaults to 'master'.  See the
-	`--remote` documentation in linkgit:git-submodule[1] for details.
+	If the option is not specified, it defaults to 'master'.  A special
+	value of `.` is used to indicate that the name of the branch in the
+	submodule should be the same name as the current branch in the
+	current repository.  See the `--remote` documentation in
+	linkgit:git-submodule[1] for details.
 
 submodule.<name>.fetchRecurseSubmodules::
 	This option can be used to control recursive fetching of this
-- 
2.10.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] submodules: update documentaion for submodule branches
  2016-10-19 20:42 [PATCH] submodules: update documentaion for submodule branches Brandon Williams
@ 2016-10-19 20:45 ` Stefan Beller
  2016-10-19 21:42 ` Junio C Hamano
  1 sibling, 0 replies; 5+ messages in thread
From: Stefan Beller @ 2016-10-19 20:45 UTC (permalink / raw)
  To: Brandon Williams; +Cc: git@vger.kernel.org

On Wed, Oct 19, 2016 at 1:42 PM, Brandon Williams <bmwill@google.com> wrote:
> Update the documentaion for the the special value `.` to indicate that
> it signifies that the tracking branch in the submodule should be the
> same as the current branch in the superproject.

For reference of other reviewers:
See 4d7bc52b178bffe9e484c4dcd92d5353e2ce716f
as well as https://gerrit-review.googlesource.com/Documentation/user-submodules.html

Thanks,
Stefan

>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  Documentation/git-submodule.txt | 4 +++-
>  Documentation/gitmodules.txt    | 7 +++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index bf3bb37..d841573 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -259,7 +259,9 @@ OPTIONS
>  --branch::
>         Branch of repository to add as submodule.
>         The name of the branch is recorded as `submodule.<name>.branch` in
> -       `.gitmodules` for `update --remote`.
> +       `.gitmodules` for `update --remote`.  A special value of `.` is used to
> +       indicate that the name of the branch in the submodule should be the
> +       same name as the current branch in the current repository.
>
>  -f::
>  --force::
> diff --git a/Documentation/gitmodules.txt b/Documentation/gitmodules.txt
> index 10dcc08..8f7c50f 100644
> --- a/Documentation/gitmodules.txt
> +++ b/Documentation/gitmodules.txt
> @@ -50,8 +50,11 @@ submodule.<name>.update::
>
>  submodule.<name>.branch::
>         A remote branch name for tracking updates in the upstream submodule.
> -       If the option is not specified, it defaults to 'master'.  See the
> -       `--remote` documentation in linkgit:git-submodule[1] for details.
> +       If the option is not specified, it defaults to 'master'.  A special
> +       value of `.` is used to indicate that the name of the branch in the
> +       submodule should be the same name as the current branch in the
> +       current repository.  See the `--remote` documentation in
> +       linkgit:git-submodule[1] for details.
>
>  submodule.<name>.fetchRecurseSubmodules::
>         This option can be used to control recursive fetching of this
> --
> 2.10.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] submodules: update documentaion for submodule branches
  2016-10-19 20:42 [PATCH] submodules: update documentaion for submodule branches Brandon Williams
  2016-10-19 20:45 ` Stefan Beller
@ 2016-10-19 21:42 ` Junio C Hamano
  2016-10-19 22:43   ` Junio C Hamano
  1 sibling, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2016-10-19 21:42 UTC (permalink / raw)
  To: Brandon Williams; +Cc: git, sbeller

Brandon Williams <bmwill@google.com> writes:

> Update the documentaion for the the special value `.` to indicate that
> it signifies that the tracking branch in the submodule should be the
> same as the current branch in the superproject.

Thanks.  Will typofix while extending with info supplied by Stefan
like so:

    submodules doc: update documentation for "." used for submodule branches

    4d7bc52b17 ("submodule update: allow '.' for branch value",
    2016-08-03) adopted from Gerrit a feature to set "." as a special
    value of "submodule.<name>.branch" in .gitmodules file to indicate
    that it signifies that the tracking branch in the submodule should
    be the same as the current branch in the superproject.

    Update the documentation to describe this.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] submodules: update documentaion for submodule branches
  2016-10-19 21:42 ` Junio C Hamano
@ 2016-10-19 22:43   ` Junio C Hamano
  2016-10-19 23:01     ` Brandon Williams
  0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2016-10-19 22:43 UTC (permalink / raw)
  To: Brandon Williams; +Cc: git, sbeller

Junio C Hamano <gitster@pobox.com> writes:

> Brandon Williams <bmwill@google.com> writes:
>
>> Update the documentaion for the the special value `.` to indicate that
>> it signifies that the tracking branch in the submodule should be the
>> same as the current branch in the superproject.
>
> Thanks.  Will typofix while extending with info supplied by Stefan
> like so:

Ugh.  Should have proof-read before sending it out.

>     4d7bc52b17 ("submodule update: allow '.' for branch value",
>     2016-08-03) adopted from Gerrit a feature to set "." as a special
>     value of "submodule.<name>.branch" in .gitmodules file to indicate
>     that it signifies that the tracking branch in the submodule should
>     be the same as the current branch in the superproject.

    ... in .gitmodules file to indicate that the tracking branch in
    the submodule should be ...

"to indicate that it signifies that" was overly redundant.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] submodules: update documentaion for submodule branches
  2016-10-19 22:43   ` Junio C Hamano
@ 2016-10-19 23:01     ` Brandon Williams
  0 siblings, 0 replies; 5+ messages in thread
From: Brandon Williams @ 2016-10-19 23:01 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, sbeller

On 10/19, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Brandon Williams <bmwill@google.com> writes:
> >
> >> Update the documentaion for the the special value `.` to indicate that
> >> it signifies that the tracking branch in the submodule should be the
> >> same as the current branch in the superproject.
> >
> > Thanks.  Will typofix while extending with info supplied by Stefan
> > like so:
> 
> Ugh.  Should have proof-read before sending it out.
> 
> >     4d7bc52b17 ("submodule update: allow '.' for branch value",
> >     2016-08-03) adopted from Gerrit a feature to set "." as a special
> >     value of "submodule.<name>.branch" in .gitmodules file to indicate
> >     that it signifies that the tracking branch in the submodule should
> >     be the same as the current branch in the superproject.
> 
>     ... in .gitmodules file to indicate that the tracking branch in
>     the submodule should be ...
> 
> "to indicate that it signifies that" was overly redundant.

Sorry that seems to have stemed from my poor commit message.

-- 
Brandon Williams

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-10-19 23:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19 20:42 [PATCH] submodules: update documentaion for submodule branches Brandon Williams
2016-10-19 20:45 ` Stefan Beller
2016-10-19 21:42 ` Junio C Hamano
2016-10-19 22:43   ` Junio C Hamano
2016-10-19 23:01     ` Brandon Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).