From: Tobias Klauser <tklauser@distanz.ch>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] diffcore-delta: remove unused parameter to diffcore_count_changes()
Date: Fri, 4 Nov 2016 17:46:58 +0100 [thread overview]
Message-ID: <20161104164658.GB819@distanz.ch> (raw)
In-Reply-To: <20161104163714.zwzfbmrklzwuaw6u@sigill.intra.peff.net>
On 2016-11-04 at 17:37:14 +0100, Jeff King <peff@peff.net> wrote:
> On Fri, Nov 04, 2016 at 11:24:36AM +0100, Tobias Klauser wrote:
>
> > The delta_limit parameter to diffcore_count_changes() has been unused
> > since commit c06c79667c95 ("diffcore-rename: somewhat optimized.").
> > Remove the parameter and adjust all callers.
>
> Sounds like a good idea to get rid of an unused parameter, but I think
> this went away in ba23bbc8e (diffcore-delta: make change counter to byte
> oriented again., 2006-03-04).
Ugh, I must have fat-fingered the commit id. Will update the description
accordingly for v2.
Thanks!
Tobias
prev parent reply other threads:[~2016-11-04 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 10:24 [PATCH] diffcore-delta: remove unused parameter to diffcore_count_changes() Tobias Klauser
2016-11-04 16:37 ` Jeff King
2016-11-04 16:46 ` Tobias Klauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104164658.GB819@distanz.ch \
--to=tklauser@distanz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).