git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>
To: git@vger.kernel.org
Cc: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>
Subject: [PATCH 4/4] doc: omit needless "for"
Date: Fri,  9 Dec 2016 16:51:12 +0100	[thread overview]
Message-ID: <20161209155112.2112-5-kristoffer.haugsbakk@gmail.com> (raw)
In-Reply-To: <20161209155112.2112-1-kristoffer.haugsbakk@gmail.com>

What was intended was perhaps "... plumbing does for you" ("you" added), but
simply omitting the word "for" is more terse and gets the intended point across
just as well, if not more so.

I originally went with the approach of writing "for you", but Junio C
Hamano suggested this approach instead.

Signed-off-by: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>
---

Notes (kristoffers):
    The original patch was sent to the mailing list on 2016-11-04, and Junio
    replied with his suggested correction on 2016-11-10; see the cover
    letter.

 Documentation/gitcore-tutorial.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt
index 72ca9c1ef..22309cfb4 100644
--- a/Documentation/gitcore-tutorial.txt
+++ b/Documentation/gitcore-tutorial.txt
@@ -25,7 +25,7 @@ you want to understand Git's internals.
 The core Git is often called "plumbing", with the prettier user
 interfaces on top of it called "porcelain". You may not want to use the
 plumbing directly very often, but it can be good to know what the
-plumbing does for when the porcelain isn't flushing.
+plumbing does when the porcelain isn't flushing.
 
 Back when this document was originally written, many porcelain
 commands were shell scripts. For simplicity, it still uses them as
-- 
2.11.0


  parent reply	other threads:[~2016-12-09 15:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09 15:51 [PATCH 0/4] doc: fixes to gitcore-tutorial.txt Kristoffer Haugsbakk
2016-12-09 15:51 ` [PATCH 1/4] doc: add articles (grammar) Kristoffer Haugsbakk
2016-12-10 20:28   ` Philip Oakley
2016-12-13 13:05     ` Kristoffer Haugsbakk
2016-12-13 18:11       ` Junio C Hamano
2016-12-13 21:34         ` Kristoffer Haugsbakk
2016-12-09 15:51 ` [PATCH 2/4] doc: add verb in front of command to run Kristoffer Haugsbakk
2016-12-10 20:48   ` Philip Oakley
2016-12-09 15:51 ` [PATCH 3/4] doc: make the intent of sentence clearer Kristoffer Haugsbakk
2016-12-10 20:52   ` Philip Oakley
2016-12-13 13:23     ` Kristoffer Haugsbakk
2016-12-09 15:51 ` Kristoffer Haugsbakk [this message]
2016-12-11 13:04   ` [PATCH 4/4] doc: omit needless "for" Philip Oakley
2016-12-11 14:08     ` Philip Oakley
2016-12-09 23:13 ` [PATCH 0/4] doc: fixes to gitcore-tutorial.txt Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161209155112.2112-5-kristoffer.haugsbakk@gmail.com \
    --to=kristoffer.haugsbakk@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).