git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gitk: Makefile: create install bin directory
@ 2016-05-05 17:46 Vasco Almeida
  2016-12-12  0:01 ` Paul Mackerras
  0 siblings, 1 reply; 2+ messages in thread
From: Vasco Almeida @ 2016-05-05 17:46 UTC (permalink / raw)
  To: git; +Cc: Vasco Almeida, Paul Mackerras

Force creation of destination bin directory. Before this commit, gitk
would fail to install if this directory didn't already exist.

Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 5acdc90..5bdd52a 100644
--- a/Makefile
+++ b/Makefile
@@ -50,6 +50,7 @@ endif
 all:: gitk-wish $(ALL_MSGFILES)
 
 install:: all
+	$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
 	$(INSTALL) -m 755 gitk-wish '$(DESTDIR_SQ)$(bindir_SQ)'/gitk
 	$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(msgsdir_SQ)'
 	$(foreach p,$(ALL_MSGFILES), $(INSTALL) -m 644 $p '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gitk: Makefile: create install bin directory
  2016-05-05 17:46 [PATCH] gitk: Makefile: create install bin directory Vasco Almeida
@ 2016-12-12  0:01 ` Paul Mackerras
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 2016-12-12  0:01 UTC (permalink / raw)
  To: Vasco Almeida; +Cc: git

On Thu, May 05, 2016 at 05:46:32PM +0000, Vasco Almeida wrote:
> Force creation of destination bin directory. Before this commit, gitk
> would fail to install if this directory didn't already exist.
> 
> Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>

Thanks, applied (with slight tweak to commit message).

Paul.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-12  1:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-05 17:46 [PATCH] gitk: Makefile: create install bin directory Vasco Almeida
2016-12-12  0:01 ` Paul Mackerras

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).