git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Stefan Dotterweich <stefandotterweich@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] gitk: Fix missing commits when using -S or -G
Date: Mon, 12 Dec 2016 11:39:19 +1100	[thread overview]
Message-ID: <20161212003919.GE18316@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <1f857709-3c47-d4a1-b858-3288347416f8@gmx.de>

On Sat, Jun 04, 2016 at 10:47:16AM +0200, Stefan Dotterweich wrote:
> When -S or -G is used as a filter option, the resulting commit list
> rarely contains all matching commits. Only a certain number of commits
> are displayed and the rest are missing.
> 
> "git log --boundary -S" does not return as many boundary commits as you
> might expect. gitk makes up for this in closevargs() by adding missing
> parent (boundary) commits. However, it does not change $numcommits,
> which limits how many commits are shown. In the end, some commits at the
> end of the commit list are simply not shown.
> 
> Change $numcommits whenever a missing parent is added.
> 
> Signed-off-by: Stefan Dotterweich <stefandotterweich@gmx.de>

Thanks, applied, with slight tweaks to the commit message.

Paul.

      reply	other threads:[~2016-12-12  1:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 11:56 [PATCH] gitk: Fix missing commits when using -S or -G Stefan Dotterweich
2016-05-06 12:16 ` [PATCH v2] " Stefan Dotterweich
2016-05-09  3:45   ` Paul Mackerras
2016-05-09  5:33     ` Stefan Dotterweich
2016-06-04  8:47       ` [PATCH v3] " Stefan Dotterweich
2016-12-12  0:39         ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161212003919.GE18316@fergus.ozlabs.ibm.com \
    --to=paulus@ozlabs.org \
    --cc=git@vger.kernel.org \
    --cc=stefandotterweich@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).