* [PATCH] git-svn: allow "0" in SVN path components
@ 2016-12-12 11:09 Eric Wong
2016-12-12 19:04 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2016-12-12 11:09 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Blindly checking a path component for falsiness is unwise, as
"0" is false to Perl, but a valid pathname component for SVN
(or any filesystem).
Found via random code reading.
Signed-off-by: Eric Wong <e@80x24.org>
---
Junio: this bugfix should go to "maint".
Will push along with a doc fix for Juergen.
perl/Git/SVN/Ra.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index e764696801..56ad9870bc 100644
--- a/perl/Git/SVN/Ra.pm
+++ b/perl/Git/SVN/Ra.pm
@@ -606,7 +606,7 @@ sub minimize_url {
my $latest = $ra->get_latest_revnum;
$ra->get_log("", $latest, 0, 1, 0, 1, sub {});
};
- } while ($@ && ($c = shift @components));
+ } while ($@ && defined($c = shift @components));
return canonicalize_url($url);
}
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] git-svn: allow "0" in SVN path components
2016-12-12 11:09 [PATCH] git-svn: allow "0" in SVN path components Eric Wong
@ 2016-12-12 19:04 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2016-12-12 19:04 UTC (permalink / raw)
To: Eric Wong; +Cc: git
Eric Wong <e@80x24.org> writes:
> Blindly checking a path component for falsiness is unwise, as
> "0" is false to Perl, but a valid pathname component for SVN
> (or any filesystem).
>
> Found via random code reading.
>
> Signed-off-by: Eric Wong <e@80x24.org>
> ---
> Junio: this bugfix should go to "maint".
> Will push along with a doc fix for Juergen.
>
> perl/Git/SVN/Ra.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
> index e764696801..56ad9870bc 100644
> --- a/perl/Git/SVN/Ra.pm
> +++ b/perl/Git/SVN/Ra.pm
> @@ -606,7 +606,7 @@ sub minimize_url {
> my $latest = $ra->get_latest_revnum;
> $ra->get_log("", $latest, 0, 1, 0, 1, sub {});
> };
> - } while ($@ && ($c = shift @components));
> + } while ($@ && defined($c = shift @components));
>
> return canonicalize_url($url);
> }
Makes sense to me. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-12 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-12 11:09 [PATCH] git-svn: allow "0" in SVN path components Eric Wong
2016-12-12 19:04 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).