git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brandon Williams <bmwill@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: What's cooking in git.git (Dec 2016, #02; Mon, 12)
Date: Tue, 13 Dec 2016 13:37:06 -0800	[thread overview]
Message-ID: <20161213213706.GA4121@google.com> (raw)
In-Reply-To: <xmqqeg1b39yi.fsf@gitster.mtv.corp.google.com>

On 12/13, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > ok 13 - grep tree and more pathspecs
> >
> > expecting success: 
> > 	git init parent &&
> > 	test_when_finished "rm -rf parent" &&
> > 	echo "foobar" >"parent/fi:le" &&
> > 	git -C parent add "fi:le" &&
> > 	git -C parent commit -m "add fi:le" &&
> > ...
> > 	test_cmp expect actual
> >
> > ++ git init parent
> > Initialized empty Git repository in C:/git-sdk-64/usr/src/git/wip3/t/trash
> > directory.t7814-grep-recurse-submodules/parent/.git/
> > ++ test_when_finished 'rm -rf parent'
> > ++ test 0 = 0
> > ++ test_cleanup='{ rm -rf parent
> > 		} && (exit "$eval_ret"); eval_ret=$?; :'
> > ++ echo foobar
> > ++ git -C parent add fi:le
> > fatal: pathspec 'fi:le' did not match any files
> 
> I think !MINGW prereq is missing?

Yes the !MINGW prereq is missing on this one test since the test uses a
filename with a ":" which isn't supported on windows.  I have that
change made in my local grep branch but I haven't sent out a reroll of
the series yet due to the underlying race-condition that existed (due to
the way realpath was being calculated).  I'll send out a reroll of the
series once the discussion on bw/realpath-wo-chdir has concluded (as
the grep series is now dependent on it).

-- 
Brandon Williams

      reply	other threads:[~2016-12-13 21:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 21:30 What's cooking in git.git (Dec 2016, #02; Mon, 12) Junio C Hamano
2016-12-13 15:39 ` Johannes Schindelin
2016-12-13 16:09   ` Junio C Hamano
2016-12-13 15:42 ` Johannes Schindelin
2016-12-13 16:13   ` Junio C Hamano
2016-12-19 10:49     ` Johannes Schindelin
2016-12-19 18:17       ` Junio C Hamano
2016-12-13 19:19 ` Johannes Schindelin
2016-12-13 19:28   ` Junio C Hamano
2016-12-13 21:37     ` Brandon Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161213213706.GA4121@google.com \
    --to=bmwill@google.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).