From: Jeff King <peff@peff.net>
To: David Turner <dturner@twosigma.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 1/2] auto gc: don't write bitmaps for incremental repacks
Date: Fri, 23 Dec 2016 21:57:30 -0500 [thread overview]
Message-ID: <20161224025730.vwz2k4af6z6piinl@sigill.intra.peff.net> (raw)
In-Reply-To: <1482541735-21346-2-git-send-email-dturner@twosigma.com>
On Fri, Dec 23, 2016 at 08:08:54PM -0500, David Turner wrote:
> + git gc --auto 2>err &&
> + test_i18ngrep ! "^warning:" err &&
> + ls .git/objects/pack/ | grep -v bitmap | sort >post_packs &&
I'm not sure why you omit the bitmap here. It shouldn't change, right?
In that case it should not be mentioned by comm, and not impact the
counts you check later (and in the off chance that a new .bitmap is
created, we'd want to know and fail the test, I would think).
> + comm --output-delimiter , -1 -3 existing_packs post_packs >new &&
> + comm --output-delimiter , -2 -3 existing_packs post_packs >del &&
I don't think --output-delimiter will be portable beyond GNU comm.
> + test_line_count = 0 del && # No packs are deleted
> + test_line_count = 2 new # There is one new pack and its .idx
This logic makes sense (and is much nicer than the previous round).
-Peff
next prev parent reply other threads:[~2016-12-24 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 1:08 [PATCH v3 0/2] pack bitmaps and incremental packing David Turner
2016-12-24 1:08 ` [PATCH v3 1/2] auto gc: don't write bitmaps for incremental repacks David Turner
2016-12-24 2:57 ` Jeff King [this message]
2016-12-24 1:08 ` [PATCH v3 2/2] repack: die on incremental + write-bitmap-index David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161224025730.vwz2k4af6z6piinl@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).