From: Jeff King <peff@peff.net>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] branch_get_push: do not segfault when HEAD is detached
Date: Fri, 6 Jan 2017 20:31:26 -0500 [thread overview]
Message-ID: <20170107013126.4ub726mf73y36of3@sigill.intra.peff.net> (raw)
In-Reply-To: <87bmvjll8m.fsf@kyleam.com>
On Fri, Jan 06, 2017 at 08:19:53PM -0500, Kyle Meyer wrote:
> > The other option is just "git checkout --detach", which is also used in
> > the test suite. I tend to prefer it because it's a little more obvious
> > to a reader.
>
> True, that does seem clearer. Seems I should've waited a bit before
> sending out v2.
I think it's OK either way. Junio can also mark it up while applying,
too, if he has a preference.
-Peff
next prev parent reply other threads:[~2017-01-07 1:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 4:56 [PATCH] branch_get_push: do not segfault when HEAD is detached Kyle Meyer
2017-01-06 6:18 ` Jeff King
2017-01-06 13:41 ` Johannes Schindelin
2017-01-07 1:09 ` Kyle Meyer
2017-01-07 1:11 ` Jeff King
2017-01-07 1:19 ` Kyle Meyer
2017-01-07 1:31 ` Jeff King [this message]
2017-01-09 10:32 ` Junio C Hamano
2017-01-07 1:12 ` [PATCH v2] " Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107013126.4ub726mf73y36of3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).