* [PATCH] request-pull: drop old USAGE stuff
@ 2017-01-15 17:46 Wolfram Sang
2017-01-16 0:23 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2017-01-15 17:46 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Wolfram Sang
request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
USAGE and LONG_USAGE anymore.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
git-request-pull.sh | 3 ---
1 file changed, 3 deletions(-)
Index: git-2.11.0/git-request-pull.sh
===================================================================
--- git-2.11.0.orig/git-request-pull.sh
+++ git-2.11.0/git-request-pull.sh
@@ -4,9 +4,6 @@
# This file is licensed under the GPL v2, or a later version
# at the discretion of Linus Torvalds.
-USAGE='<start> <url> [<end>]'
-LONG_USAGE='Summarizes the changes between two commits to the standard output,
-and includes the given URL in the generated summary.'
SUBDIRECTORY_OK='Yes'
OPTIONS_KEEPDASHDASH=
OPTIONS_STUCKLONG=
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] request-pull: drop old USAGE stuff
2017-01-15 17:46 [PATCH] request-pull: drop old USAGE stuff Wolfram Sang
@ 2017-01-16 0:23 ` Junio C Hamano
2017-01-16 23:51 ` Jeff King
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2017-01-16 0:23 UTC (permalink / raw)
To: Wolfram Sang; +Cc: git
Wolfram Sang <wsa@the-dreams.de> writes:
> request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
> USAGE and LONG_USAGE anymore.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
Makes sense. These are not used anywhere after we switched to use
parse-options.
Thanks.
>
> git-request-pull.sh | 3 ---
> 1 file changed, 3 deletions(-)
>
> Index: git-2.11.0/git-request-pull.sh
> ===================================================================
> --- git-2.11.0.orig/git-request-pull.sh
> +++ git-2.11.0/git-request-pull.sh
> @@ -4,9 +4,6 @@
> # This file is licensed under the GPL v2, or a later version
> # at the discretion of Linus Torvalds.
>
> -USAGE='<start> <url> [<end>]'
> -LONG_USAGE='Summarizes the changes between two commits to the standard output,
> -and includes the given URL in the generated summary.'
> SUBDIRECTORY_OK='Yes'
> OPTIONS_KEEPDASHDASH=
> OPTIONS_STUCKLONG=
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] request-pull: drop old USAGE stuff
2017-01-16 0:23 ` Junio C Hamano
@ 2017-01-16 23:51 ` Jeff King
0 siblings, 0 replies; 3+ messages in thread
From: Jeff King @ 2017-01-16 23:51 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Wolfram Sang, git
On Sun, Jan 15, 2017 at 04:23:02PM -0800, Junio C Hamano wrote:
> Wolfram Sang <wsa@the-dreams.de> writes:
>
> > request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
> > USAGE and LONG_USAGE anymore.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
>
> Makes sense. These are not used anywhere after we switched to use
> parse-options.
It does seem a shame that parse-options does not show this explanatory
text. But I guess nobody really cares that much, and you can always use
"--help" to get even more details.
-Peff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-16 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-15 17:46 [PATCH] request-pull: drop old USAGE stuff Wolfram Sang
2017-01-16 0:23 ` Junio C Hamano
2017-01-16 23:51 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).