From: Wolfram Sang <wsa@the-dreams.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC for GIT] pull-request: add praise to people doing QA
Date: Thu, 19 Jan 2017 23:02:58 +0100 [thread overview]
Message-ID: <20170119220257.GB1747@katana> (raw)
In-Reply-To: <xmqq7f5qzqx3.fsf@gitster.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
> > I didn't know about trailers before. As I undestand it, I could use
> > "Tested-by" as the key, and the commit subject as the value. This list
> > then could be parsed and brought into proper output shape. It would
> > simplify the subject parsing, but most things my AWK script currently
> > does would still need to stay or to be reimplemented (extracting names
> > from tags, creating arrays of tags given by $name). Am I correct?
>
> That is not exactly what I had in mind. I was wondering if we can
> do without any external script, implementing the logic you added
> inside shortlog with an extra option that triggers the whole thing,
> which may call into the same trailers API as used by the
> interpret-trailers command to do the parsing and picking out parts.
Sorry for being unclear. That's what I meant with "or to be
reimplemented". I should have added "in C".
I am afraid this also requires more time than I am willing to
spend on this issue. Seems my hack is going to stay for a while here.
However, thank you for your time and assisting me with pointers!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-01-19 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 18:30 [RFC for GIT] pull-request: add praise to people doing QA Wolfram Sang
2017-01-16 0:35 ` Junio C Hamano
2017-01-16 4:05 ` Jacob Keller
2017-01-19 20:43 ` Wolfram Sang
2017-01-19 21:20 ` Jeff King
2017-01-19 23:42 ` Jacob Keller
2017-01-20 0:06 ` Joe Perches
2017-01-20 0:13 ` Jacob Keller
2017-01-19 21:22 ` Junio C Hamano
2017-01-19 22:02 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119220257.GB1747@katana \
--to=wsa@the-dreams.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).