From: Stefan Hajnoczi <stefanha@redhat.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>,
gitster@pobox.com, Brandon Williams <bmwill@google.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH v2 0/2] grep: make output consistent with revision syntax
Date: Fri, 20 Jan 2017 17:11:24 +0000 [thread overview]
Message-ID: <20170120171126.16269-1-stefanha@redhat.com> (raw)
v2:
* Use obj->type instead of re-parsing name for delimiter
(Followed Brandon's suggestion but named the variable 'delim' since that
name is used in other places and 'del' is used for deletion.)
* Add tests
* Update Patch 1 commit description with a more relevant example
* PATCH instead of RFC, now works with all documented git-rev-parse(1) syntax
git-grep(1)'s output is not consistent with git-rev-parse(1) revision syntax.
This means you cannot take "rev:path/to/file.c: foo();" output from git-grep(1)
and expect "git show rev:path/to/file.c" to work. See the individual patches
for examples of command-lines that produce invalid output.
Stefan Hajnoczi (2):
grep: only add delimiter if there isn't one already
grep: use '/' delimiter for paths
builtin/grep.c | 8 +++++++-
t/t7810-grep.sh | 26 ++++++++++++++++++++++++++
2 files changed, 33 insertions(+), 1 deletion(-)
--
2.9.3
next reply other threads:[~2017-01-20 17:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 17:11 Stefan Hajnoczi [this message]
2017-01-20 17:11 ` [PATCH v2 1/2] grep: only add delimiter if there isn't one already Stefan Hajnoczi
2017-01-20 22:19 ` Junio C Hamano
2017-01-20 17:11 ` [PATCH v2 2/2] grep: use '/' delimiter for paths Stefan Hajnoczi
2017-01-20 22:18 ` Junio C Hamano
2017-01-20 23:51 ` Brandon Williams
2017-02-07 15:04 ` Stefan Hajnoczi
2017-02-07 19:50 ` Jeff King
2017-02-07 20:24 ` Junio C Hamano
2017-02-07 20:37 ` Junio C Hamano
2017-02-09 3:58 ` Jeff King
2017-02-09 5:14 ` Junio C Hamano
2017-02-09 5:20 ` Jeff King
2017-02-14 9:43 ` Stefan Hajnoczi
2017-01-20 23:11 ` [PATCH v2 0/2] grep: make output consistent with revision syntax Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120171126.16269-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).