From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff King <peff@peff.net>
Subject: [PATCH 3/7] Documentation: remove unneeded argument in cat-texi.perl
Date: Sat, 21 Jan 2017 21:59:08 +0000 [thread overview]
Message-ID: <20170121215912.246691-4-sandals@crustytoothpaste.net> (raw)
In-Reply-To: <20170121215912.246691-1-sandals@crustytoothpaste.net>
The newly-added use of the warnings pragma exposes that the $menu[0]
argument to printf has long been silently ignored, since there is no
format specifier for it. It doesn't appear that the argument is
actually needed, either: there is no reason to insert the name of one
particular documentation page anywhere in the header that's being
generated.
Remove the unused argument, and since the format specification
functionality is no longer needed, convert the printf to a simple print.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
Documentation/cat-texi.perl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/cat-texi.perl b/Documentation/cat-texi.perl
index 1bc84d3c7..14d2f8341 100755
--- a/Documentation/cat-texi.perl
+++ b/Documentation/cat-texi.perl
@@ -20,7 +20,7 @@ while (<STDIN>) {
}
close $tmp;
-printf '\input texinfo
+print '\input texinfo
@setfilename gitman.info
@documentencoding UTF-8
@dircategory Development
@@ -31,7 +31,7 @@ printf '\input texinfo
@top Git Manual Pages
@documentlanguage en
@menu
-', $menu[0];
+';
for (@menu) {
print "* ${_}::\n";
next prev parent reply other threads:[~2017-01-21 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 21:59 [PATCH 0/7] Macro for Asciidoctor support brian m. carlson
2017-01-21 21:59 ` [PATCH 1/7] Documentation: fix warning in cat-texi.perl brian m. carlson
2017-01-21 21:59 ` [PATCH 2/7] Documentation: modernize cat-texi.perl brian m. carlson
2017-01-21 21:59 ` brian m. carlson [this message]
2017-01-21 21:59 ` [PATCH 4/7] Documentation: sort sources for gitman.texi brian m. carlson
2017-01-21 21:59 ` [PATCH 5/7] Documentation: add XSLT to fix DocBook for Texinfo brian m. carlson
2017-01-21 21:59 ` [PATCH 6/7] Documentation: move dblatex arguments into variable brian m. carlson
2017-01-22 1:03 ` Øyvind A. Holm
2017-01-21 21:59 ` [PATCH 7/7] Makefile: add a knob to enable the use of Asciidoctor brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170121215912.246691-4-sandals@crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).