From: Olaf Hering <olaf@aepfle.de>
To: git@vger.kernel.org
Subject: missing handling of "No newline at end of file" in git am
Date: Tue, 14 Feb 2017 21:11:04 +0100 [thread overview]
Message-ID: <20170214201104.GA26407@aepfle.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
How is git send-email and git am supposed to handle a text file which
lacks a newline at the very end? This is about git 2.11.0.
Right now the patch in an email generated with 'git send-email' ends
with '\ No newline at end of file', which 'git am' can not handle. To
me it looks like whatever variant of "diff" is used does the right thing
and indicates the lack of newline. Just the used variant of "patch" does
not deal with it.
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next reply other threads:[~2017-02-14 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 20:11 Olaf Hering [this message]
2017-02-14 20:40 ` missing handling of "No newline at end of file" in git am Junio C Hamano
2017-02-14 20:51 ` Olaf Hering
2017-02-15 11:44 ` Olaf Hering
2017-02-20 8:06 ` Eric Wong
2017-02-14 20:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214201104.GA26407@aepfle.de \
--to=olaf@aepfle.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).