From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 88EF92021B for ; Tue, 21 Feb 2017 07:12:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbdBUHMN (ORCPT ); Tue, 21 Feb 2017 02:12:13 -0500 Received: from cloud.peff.net ([104.130.231.41]:59121 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbdBUHMM (ORCPT ); Tue, 21 Feb 2017 02:12:12 -0500 Received: (qmail 12947 invoked by uid 109); 21 Feb 2017 07:12:11 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Tue, 21 Feb 2017 07:12:11 +0000 Received: (qmail 29919 invoked by uid 111); 21 Feb 2017 07:12:14 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Tue, 21 Feb 2017 02:12:14 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 21 Feb 2017 02:12:09 -0500 Date: Tue, 21 Feb 2017 02:12:09 -0500 From: Jeff King To: Kyle Meyer Cc: Junio C Hamano , git@vger.kernel.org Subject: Re: [PATCH v2 0/4] delete_ref: support reflog messages Message-ID: <20170221071209.2n4jer4wuyn23ci3@sigill.intra.peff.net> References: <20170217035800.13214-1-kyle@kyleam.com> <20170221011035.847-1-kyle@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170221011035.847-1-kyle@kyleam.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Feb 20, 2017 at 08:10:31PM -0500, Kyle Meyer wrote: > Kyle Meyer (4): > delete_ref: accept a reflog message argument > update-ref: pass reflog message to delete_ref() > rename_ref: replace empty message in HEAD's log > branch: record creation of renamed branch in HEAD's log These look good to me. I think you did a nice job of summarizing the discussion in the commit messages. -Peff