From: David Aguilar <davvid@gmail.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] Remove outdated info in difftool manpage
Date: Sat, 4 Mar 2017 12:46:58 -0800 [thread overview]
Message-ID: <20170304204658.a3xo2j2aggf22rd5@gmail.com> (raw)
In-Reply-To: <20170303212836.GB13790@arch-attack.localdomain>
On Fri, Mar 03, 2017 at 01:28:36PM -0800, Denton Liu wrote:
> On Fri, Mar 03, 2017 at 04:46:36PM +0100, Johannes Schindelin wrote:
> > Hi Denton (or should I address you as Liu?),
> Denton is fine, thanks.
> >
> > On Fri, 3 Mar 2017, Denton Liu wrote:
> >
> > > When difftool was rewritten in C, it removed the capability to read
> > > fallback configs from mergetool. This changes the documentation to
> > > reflect this.
> >
> > Thanks for pointing that out. But that is probably an oversight on my
> > part, not an intentional change...
> Do you expect to be submitting a patch for this soon? Or, if not, would
> it be fine if I went ahead and did it?
Thanks for spotting this. It'd be good to fix this so
I'm sure no one would mind if you submitted a patch ;-)
I'd be happy to test your patch if you have one.
--
David
prev parent reply other threads:[~2017-03-04 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 11:57 [PATCH 3/3] Remove outdated info in difftool manpage Denton Liu
2017-03-03 15:46 ` Johannes Schindelin
2017-03-03 19:29 ` Junio C Hamano
2017-03-03 21:28 ` Denton Liu
2017-03-04 20:46 ` David Aguilar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170304204658.a3xo2j2aggf22rd5@gmail.com \
--to=davvid@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).