git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valery Tolstov <me@vtolstov.org>
To: sbeller@google.com
Cc: git@vger.kernel.org, me@vtolstov.org
Subject: Re: [PATCH] submodule--helper.c: remove duplicate code
Date: Wed,  8 Mar 2017 22:59:16 +0300	[thread overview]
Message-ID: <20170308195916.7349-1-me@vtolstov.org> (raw)
In-Reply-To: <CAGZ79kYJ9he-jhnA35m6az-T5Z58efmKsUaBw--_KzdGJPZb-Q@mail.gmail.com>

> Maybe we need to have 2293f77a081
> (connect_work_tree_and_git_dir: safely create leading directories,
> part of origin/sb/checkout-recurse-submodules, also found at
> https://public-inbox.org/git/20170306205919.9713-8-sbeller@google.com/ )
> first before we can apply this patch.

Thank you for your detailed responses. Yes, we difenitely need this
patch first. All tests passed when I applied it.


Regards,
  Valery Tolstov

  reply	other threads:[~2017-03-08 20:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 17:44 [PATCH] submodule--helper.c: remove duplicate code me
2017-03-08 18:53 ` Stefan Beller
2017-03-08 19:59   ` Valery Tolstov [this message]
2017-03-08 20:25     ` Stefan Beller
2017-03-08 23:05       ` Valery Tolstov
2017-03-08 23:15         ` Stefan Beller
2017-03-08 23:24           ` Junio C Hamano
2017-03-08 23:34             ` Stefan Beller
2017-03-09  0:03       ` [PATCH v2 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09  0:03         ` [PATCH v2 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09  0:03         ` [PATCH v2 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09  0:38           ` Brandon Williams
2017-03-09  1:27             ` [PATCH v3 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09  1:27               ` [PATCH v3 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09  1:27               ` [PATCH v3 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09 18:18                 ` Brandon Williams
2017-03-10 19:42                   ` Junio C Hamano
2017-03-10 19:49                     ` Stefan Beller
2017-03-10 20:40                       ` Junio C Hamano
2017-03-10 20:48                         ` Stefan Beller
2017-03-09 22:54                 ` Valery Tolstov
2017-03-09  0:28         ` [PATCH v2 0/2] Remove duplicate code from module_clone() Brandon Williams
2017-03-09  0:56           ` Valery Tolstov
2017-03-09 18:19             ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170308195916.7349-1-me@vtolstov.org \
    --to=me@vtolstov.org \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).