From: Brandon Williams <bmwill@google.com>
To: Valery Tolstov <me@vtolstov.org>
Cc: git@vger.kernel.org, sbeller@google.com, gitster@pobox.com
Subject: Re: [PATCH v2 0/2] Remove duplicate code from module_clone()
Date: Wed, 8 Mar 2017 16:28:18 -0800 [thread overview]
Message-ID: <20170309002818.GA153031@google.com> (raw)
In-Reply-To: <20170309000352.18330-1-me@vtolstov.org>
On 03/09, Valery Tolstov wrote:
> > Then the next step (as outlined by Documentation/SubmittingPatches)
> > is to figure out how to best present this to the mailing list; I think the best
> > way is to send out a patch series consisting of both of these 2 patches,
> > the "connect_work_tree_and_git_dir: safely create leading directories,"
> > first and then your deduplication patch.
>
> Combined two patches
>
> Stefan Beller (1):
> connect_work_tree_and_git_dir: safely create leading directories
It looks like this patch is apart of Stefan's checkout series. So I was
slightly confused when first looking at this patch since I'd seen it before.
The usual protocol would be to rebase off of Stefan's series and build
on that (assuming you have a dependency against his series), indicating
that you are doing as such in your cover letter. Though what you have
here should hopefully give the maintainer enough context to know where to
put it, so you should be good :)
>
> Valery Tolstov (1):
> submodule--helper.c: remove duplicate code
>
> builtin/submodule--helper.c | 20 ++------------------
> dir.c | 32 +++++++++++++++++++++-----------
> submodule.c | 11 ++---------
> 3 files changed, 25 insertions(+), 38 deletions(-)
>
> --
> 2.12.0.192.gbdb9d28a5
>
--
Brandon Williams
next prev parent reply other threads:[~2017-03-09 0:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 17:44 [PATCH] submodule--helper.c: remove duplicate code me
2017-03-08 18:53 ` Stefan Beller
2017-03-08 19:59 ` Valery Tolstov
2017-03-08 20:25 ` Stefan Beller
2017-03-08 23:05 ` Valery Tolstov
2017-03-08 23:15 ` Stefan Beller
2017-03-08 23:24 ` Junio C Hamano
2017-03-08 23:34 ` Stefan Beller
2017-03-09 0:03 ` [PATCH v2 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09 0:03 ` [PATCH v2 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09 0:03 ` [PATCH v2 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09 0:38 ` Brandon Williams
2017-03-09 1:27 ` [PATCH v3 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09 1:27 ` [PATCH v3 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09 1:27 ` [PATCH v3 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09 18:18 ` Brandon Williams
2017-03-10 19:42 ` Junio C Hamano
2017-03-10 19:49 ` Stefan Beller
2017-03-10 20:40 ` Junio C Hamano
2017-03-10 20:48 ` Stefan Beller
2017-03-09 22:54 ` Valery Tolstov
2017-03-09 0:28 ` Brandon Williams [this message]
2017-03-09 0:56 ` Re: [PATCH v2 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09 18:19 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309002818.GA153031@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@vtolstov.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).