* [PATCH] submodule.c: fix an 'using integer as NULL pointer' warning
@ 2017-03-16 1:02 Ramsay Jones
2017-03-16 4:49 ` Brandon Williams
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2017-03-16 1:02 UTC (permalink / raw)
To: Brandon Williams; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Brandon,
If you need to re-roll your 'bw/submodule-is-active' branch, could
you please squash this into the relevant patch (commit 20d59ab335,
"submodule: decouple url and submodule existence", 13-03-2017).
Thanks!
ATB,
Ramsay Jones
submodule.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index 800283154..a77d11cc4 100644
--- a/submodule.c
+++ b/submodule.c
@@ -245,7 +245,7 @@ int is_submodule_initialized(const char *path)
argv_array_push(&args, item->string);
}
- parse_pathspec(&ps, 0, 0, 0, args.argv);
+ parse_pathspec(&ps, 0, 0, NULL, args.argv);
ret = match_pathspec(&ps, path, strlen(path), 0, NULL, 1);
argv_array_clear(&args);
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] submodule.c: fix an 'using integer as NULL pointer' warning
2017-03-16 1:02 [PATCH] submodule.c: fix an 'using integer as NULL pointer' warning Ramsay Jones
@ 2017-03-16 4:49 ` Brandon Williams
0 siblings, 0 replies; 2+ messages in thread
From: Brandon Williams @ 2017-03-16 4:49 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
On 03/16, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Brandon,
>
> If you need to re-roll your 'bw/submodule-is-active' branch, could
> you please squash this into the relevant patch (commit 20d59ab335,
> "submodule: decouple url and submodule existence", 13-03-2017).
Thanks for catching this, I've squashed it into my local branch and I'm
planning on sending out a reroll in a day or so.
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> submodule.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/submodule.c b/submodule.c
> index 800283154..a77d11cc4 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -245,7 +245,7 @@ int is_submodule_initialized(const char *path)
> argv_array_push(&args, item->string);
> }
>
> - parse_pathspec(&ps, 0, 0, 0, args.argv);
> + parse_pathspec(&ps, 0, 0, NULL, args.argv);
> ret = match_pathspec(&ps, path, strlen(path), 0, NULL, 1);
>
> argv_array_clear(&args);
> --
> 2.12.0
--
Brandon Williams
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-16 4:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-16 1:02 [PATCH] submodule.c: fix an 'using integer as NULL pointer' warning Ramsay Jones
2017-03-16 4:49 ` Brandon Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).